Wow Beta Report v6.0.1 (18566)

Re: Re: Re: Re; Problems oy ProblemsOK.  Test complete.  I now have an automated way of generating map data that makes it easy to see differences.I am going to check it in for the main branch and then I will re-generate for WoD and then fix Blizzard’s madness.PS:  I am working from home tomorrow, and its a long weekend.  Perhaps I wont put in a full day …

Re: Re: Re; Problems oy ProblemsOK. So I have ditched the big table formerly known as Zone2MapID.
Now I have a bunch of functions like:
[code]
DefineDungeonArea( 521,1,”The Road to Stratholme@CoTStratholme”,”CoTStratholme”,”The Road to Stratholme”)
DefineInstance( 401,0,”AlteracValley”)
DefineTerrain(1,32, 889,0,”Valley of Trials”)
[/code]
That define:
[list=1]
[*] DefineDungeonArea(): named maps on a particular floor
[*] DefineInstance(): maps with unnamed floors
[*] DefineTerrain(): maps that belong to a continent
[/list]

I am testing this for the Pandaria release and then will update for WoD.

Re: Re; Problems oy ProblemsDear Blizzard, why do you screw up the map names in a new release so horribly?
–Ludovicus

The nice part:
[code]
1903.0121 ~ WoWPro: Continent 7 [Draenor]
1903.0122 ~ WoWPro: Getting Map zones in 7
1903.0123 ~ WoWPro: Zone 1 [Ashran]
1903.0124 ~ WoWPro: Zone 2 [Frostfire Ridge]
1903.0125 ~ WoWPro: Zone 3 [Gorgrond]
1903.0126 ~ WoWPro: Zone 4 [Nagrand]
1903.0127 ~ WoWPro: Name Nagrand is duplicated for map 949 and 477
1903.0128 ~ WoWPro: Zone 5 [Shadowmoon Valley]
1903.0129 ~ WoWPro: Name Shadowmoon Valley is duplicated for map 947 and 473
1903.0130 ~ WoWPro: Zone 6 [Spires of Arak]
1903.0131 ~ WoWPro: Zone 7 [Talador]
1903.0132 ~ WoWPro: Zone 8 [Tanaan Jungle]
[/code]

The ugly part:
[code]
[12] = {
[“numFloors”] = 0,
[“mapID”] = 1011,
[“cont”] = 7,
[“zone”] = 12,
[“mapName”] = “AshranHordeFactionHub”,
},
[“AshranAllianceFactionHub”] = {
[“numFloors”] = 0,
[“mapID”] = 1009,
[“cont”] = 7,
[“zone”] = 9,
[“mapName”] = “AshranAllianceFactionHub”,
},
[/code]

Note that the logical map name “Ashran” maps into different map which correspond to different phased zones. I hope there is *something* different about these zones since now I’ll have to figure out a way of handling faction specific maps!

And why is the Horde map called 12? WTF!@$#%!!!!!!

I’m going to have to write a cross checker function to see what is different and see if any other zones have been tampered with by a deranged programmer.

Gorgrond does not even show up in my map data scans.

This is going to take longer than I anticipated.

Re: ProblemsThe “Orange” errors are a result of reworking all the guides to use the new format.  I have not reworked all of them yet, but will do so for Labor Day.  These are my fault and I need to clean them up in the main addon and will import the corrected versions into the Dranor branch.I will check in the new zones for Dranor today.If you are not going to use the recorder, turn it off.   It drastically alters the behaviour of the addon and Emmaleah and I have been going back and forth for weeks on it.   She is awfully good at stressing it, for which I am greatful.The TomTom addon is now operational.  Download the standard version and update the interface code in the .TOC files to start with 600.I wiill also incorporate Emmaleah latest guide into the tree for people to play with.I’ll try to get the Alliance version of it written to test the recorder later this week. 

ProblemsLudo has made a bunch of fixes to the recorder,  be sure and download it. (most recent one was noon saturday 8/23)The Bad guides are from the changes made to guide logic, but the old guides haven’t all been updated.  Someone (volunteers??) needs to clean it up. :)The zone not found is unavoidable until the map libraries are all updated.  I make it go away by using the zone number instead of the name when I register the guide (temp while I’m working on the guide because I get tired of seeing it)  The recorder will still put in “|Z|Town Hall|” when you are in your garrison and similarly in other subzones, but it does reduce the spam abit.Reload gives me my current saved version.  If you make the changes and leave it open without saving.  It will still load what you last saved. The newest version cuts down on the start up spam.Hope that helps!Lastly, as you can guess from my comments… I have started Horde guides.  I burned out doing both Horde and Alliance last time. So, I have very little intention of touching alliance guides.  I really hope you are interested in that.  I’ve just about finished my 2nd run thru Gorgrond, its still a mess, but I will probably be posting it soon (tomorrow?).  Without TomTom’s arrow and green dot it’s nearly impossible to finish things up.

ProblemsGetting quite a few issues:

– When I create a new character, I get the window but it’s blank. I have to do a quest before the guide kicks in.
– On start-up I get a load of lines with WoWPro in orange with Bad GuideLevels(various,20,90,nil) where various is things like LudoExpWin, KabExpZan, LudoTreasure, BitAra2025, LudoExpTan, LudoExpTel).
– On start-up, I also get WoWPro: RegisterGuide(TwiSkyRace,Dailies,…) has bad gtype
– Running through guide I’ve created, I’m getting orange WoWPro: Zone [Lunarfall] not found. Using map id 971 (no |Z| tag used), and Zone [Lunarfall] is not in Zone2MapID. Please report!
– Keep getting the following LUA error: Message: InterfaceAddOnsWoWProWoWPro_Mapping.lua:491: attempt to call global ‘WorldMapFrame_UpdateQuests’ (a nil value)
Time: 08/20/14 20:49:52
Count: 12
Stack: InterfaceAddOnsWoWProWoWPro_Mapping.lua:491: in function `MapPoint’
InterfaceAddOnsWoWProWoWPro_Broker.lua:296: in function
(tail call): ?
[C]: ?
[string “safecall Dispatcher[1]”]:9: in function <[string “safecall Dispatcher[1]”]:5>
(tail call): ?
…OnsWoWProLibrariesAceBucket-3.0AceBucket-3.0.lua:118: in function `func’
…ddOnsWoWProLibrariesAceTimer-3.0AceTimer-3.0.lua:43: in function <…ddOnsWoWProLibrariesAceTimer-3.0AceTimer-3.0.lua:36>
Locals:

– Any way we can disable the Carbite/TomTom start-up spam?
– Reload UI keeps an old copy of steps, and not the latest .lua file

Also, has anyone started any Draenor guides yet (maybe there’s a page with the various links available?), don’t want to duplicate work if it’s already been done by someone else.

Re: Recorder issuesI’ll contact you directly as I did not see any of the issues you reported, other than only the leveling module working with the recorder.

Recorder issuesI expect you noticed these yourself, but… just in case you didnt.

1) when you see a loading screen (other than initial load into game and the one time I hearthed I did not have it happen) it goes crazy returning around 1000+ errors before Bliz puts up a message that says your addons are misbehaving do you want to disable them.
Message: InterfaceAddOnsWoWProWoWPro_Broker.lua:1242: attempt to compare number with nil
Time: 08/07/14 10:00:37
Count: 3497
Stack: InterfaceAddOnsWoWProWoWPro_Broker.lua:1242: in function

Locals: self = WoWPro.EventFrame {
0 =
}
elapsed = 0.015000000596046
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = {
note = {
}
CarboniteProfileHack = defined @InterfaceAddOnsWoWProWoWPro_Broker.lua:1271
modules = {
}
CreateItemButton = defined @InterfaceAddOnsWoWProWoWPro_Widgets.lua:63
CreateHeading = defined @InterfaceAddOnsWoWProWoWPro_Widgets.lua:104
UpdateQuestTracker = defined @InterfaceAddOnsWoWProWoWPro_Events.lua:286
LoadGuideStepsReal = defined @InterfaceAddOnsWoWProWoWPro_Parser.lua:428
Tags = {
}
MapPoint = defined @InterfaceAddOnsWoWProWoWPro_Mapping.lua:452
rep = {
}
CreateSkipStepsDialog = defined @InterfaceAddOnsWoWProWoWPro_Frames.lua:654
UpdateGuide = defined @InterfaceAddOnsWoWProWoWPro_Broker.lua:194
SetDefaults = defined @InterfaceAddOnsWoWProWoWPro_Config.lua:14
Leveling = {
}
SetupGuideReal = defined @InterfaceAddOnsWoWProWoWPro_Parser.lua:467
CreateTrack = defined @InterfaceAddOnsWoWProWoWPro_Widgets.lua:53
NextStep = defined @InterfaceAddOnsWoWProWoWPro_Broker.lua:320
UnRegisterGuide = defined @InterfaceAddOnsWoWProWoWPro.lua:496
RecordButton = RecordButton {
}
chat = {
}
UnregisterEvents = defined @InterfaceAddOnsWoWProWoWPro.lua:398
ActiveStickyCount = 0
FramesLoaded = true
ResetMainFramePosition = defined @InterfaceAddOnsWoWProWoWPro_Frames.lua:15
PaddingSet = defined @InterfaceAddOnsWoWProWoWPro_Frames.lua:69
TitleText = {
}
CreateGuideTabFrame = defined @InterfaceAddOnsWoWProWoWPro_GuideList.lua:404
NewModule = defined @InterfaceAddOnsWoWProLibrariesAceAddon-3.0AceAddon-3.0.lua:266
ParseSteps = defined @InterfaceAddOnsWoWProWoWPro_Parser.lua:347
NextGuideDialog = Guide Completed {
}
SwapSteps = defined @InterfaceAddOnsWoWProWoWPro_Broker.lua:1022
actionlabels = {
}
FinalizeGuides = defined @InterfaceAddOnsWoWProWoWPro.lua:708
ActivateTab = defined @InterfaceAddOnsWoWProWoWPro_GuideList.lua:98
CreateStep = defined @InterfaceAddOnsWoWProWoWPro_Widgets.lua:34
GetName = defined @InterfaceAddOnsWoWProLibrariesAceAddon-3.0AceAddon-3.0.lua:310
name = “WoWPro”
IsInstanceZone = defined @InterfaceAddOnsWoWProWoWPro_Zones.lua:2990
noncombat = {
}
AutoCompleteQuestUpdate = defined @InterfaceAddOnsWoWProWoWPro_Events.lua:125
action = {
}
Selector_OnHide = defined @InterfaceAddOnsWoWProWoWPro_Selector.lua:167
Print = defined @InterfaceAddOnsWoWProWoWPro.lua:62
GuideLoaded = true
TargetNpcId = defined @InterfaceAddOnsWoWProWoWPro.lua:407
Scrollbar = {
}
RowColorSet = defined @InterfaceAddOnsWoWProWoWPro_Frames.lua:124
QuestLog = {
}
TakeTaxi = defined @InterfaceAddOnsWoWProWoWPro_Events.lua:20
SkipStepsCancelButton = Cancel {
}
CreateTitleBar = defined @InterfaceAddOnsWoWProWoWPro_Frames.lua:433
SetDefaultModuleLibraries = defined @InterfaceAddOnsWoWProLibrariesAceAddon-3.0AceAddon-3.0.lua:398
HSL2RGB = defined @InterfaceAddOnsWoWProWoWPro.lua:576
GuideFrame = WoWPro.GuideFrame {
}
CompleteStep = defined @InterfaceAddOnsWoWProWoWPro_Broker.lua:822
CreateFrames = defined @InterfaceAddOnsWoWProWoWPro_Frames.lua:788
EnableModule = defined @Interfac

2) Recorder seems to only work with the leveling module, not a big deal… but something to note.

3) The saved variables file for recorder is somehow getting written to when it shouldn’t. Today when I logged in, my first quest in the recorder window was the next to last quest I had picked up just before camping out this morning. (it is also at the end) The one at the end has the correct coordinates. The one at the beginning has some other the co-ords that I am not sure where came from.

I went into the saved variables file and redid it the way I wanted it and resaved it. I logged into the game and it was all messed up again. (I made a copy elsewhere so I know what I had saved)

Edit to add: I compared the saved variables file as I made it manually with what it showed after I logged in and immediately out (I logged in to see 3:75 to server shutdown). These were the changes I noted.
–As said above the extra A step as line one of the guide (I suspect it was the last item in my quest log) and the M tag values were where I was standing at the time I logged in.
–The CHAT tag I had added in, vanished
–|LVL|1| had been added to some/most lines that didn’t have it before.
–Tags (whenever they occurred) “|NC|” & “|QO|whatever the objective: 1/1” were moved to the next step above from where they should be.
–One place I had a CC tag it was moved to a different spot but still in the same step
–If you ‘subtract’ a line from your guide it sends it into an endless loop (or perhaps it was because I was trying to remove the TOP extraneous line) /reload fixes it, but also puts a new line in at the top, “A Last quest in the log|M|location you are currently standing|N|whatever NPC you have targeted|”.

Also it seems that the Bliz API for the QO’s has maybe changed. That tag doesn’t seem to be working right. When I let the recorder fill it in it shows as “1/1 quest objective” (instead of the previous “quest objective: 1/1”). I haven’t tested this fully yet.

Basically what I have discovered is that I copy and paste (using the “save” button) to a separate document regularly (like every 3 or 4 quests) and ignore what is in the saved variables file except the lines I am currently copying. Of course if I crash before copying I’m very sad 🙁

WoD, GetQuestLogTitle, and BlizzardThere is a rule when updating programs that export APIs to outside users:  [b]maintain backwards compatibility[/b].

See if you can spot the differences in these two calls to the old and new version of the function:

[code]
local questTitle, level, questTag, suggestedGroup, isHeader,
isCollapsed, isComplete, isDaily, questID, startEvent,
displayQuestID = GetQuestLogTitle(i)
local questTitle, level, suggestedGroup, isHeader, isCollapsed,
isComplete, frequency, questID, startEvent, displayQuestID,
isOnMap, hasLocalPOI, isTask, isStory = GetQuestLogTitle(i)
[/code]

The names of the variables dont matter as much as the semantics.
Here are the changes I spotted.
[list=1]
[*] The questTag is gone
[*] There are new return results at the end: isOnMap, hasLocalPOI, isTask, isStory
[/list]

Guess which change causes no problems and which one wreaks addons left and right?
Yup, deleting a return result causes everything after it to shift down by one.

Anyways.
My little Orc huntress can now track quests.
Its time to start testing the recorder for real.

Update on WoD 4Yup.  Quest tracking is broken.I tried spinning up an orc huntress and the addon could see quest completions, but not quest accepts.Quest logs scans were picking up 50 “nil” entries, but knew I had 3 active quests, but only found 1.I’ll have to dissect the new UI interface code to reverse engineer what is going on.But that will have to be for tomorrow.I’m tired.But I think it wont be long before I need testers! PS:   The Draenor addons are at https://github.com/Jiyambi/WoW-Pro-Guides/archive/Draenor.zip

Updte on WoD 3OK.   I have the basic WowPro, WowPro_Leveling and Recorder addons running now.However, Blizzard does not permit custom textures.  So any custom buttons we used to have were not usable. So I just substituted DK and Mage spell icons to work around it for now. It also makes things like TomTom almost unusable.   But map names and coordinates are up and running.However, the QuestLogFrame seems to have disappeared, and with it, which hints at deeper changes.It looks like the Quest log iinterface has had a bit of a revamp.  The code knows that I have 5 quests, but it can oonly find 5. 

Update on WoD 2So, yet again, blizzard has putzed with the mapping system.Functions like GetMapContinents() and GetMapZones() no longer return just a list of the names of the continents or zones, but return pairs of map ids and the names.Changing the map logic in WoWPro to skip every other element allows it to survive in WoD.Now I need to fix the recorder, which looks like it is suffering from button textures being undefined.Basic map functions are operating, so it will be possible to record a guide soon!Of course, I think things are going down fot maintainance in a bit.Figures.

Update on WoDBy updating the ACE3 libraries, I am now down to only 8 errors.Bartender4 is still broken, which is not serious, though I hate the default UI.But TomTom and its libraries are referencing lots of functions that no longer exist.I’ll have to file bugs and get them worked around.