by Ludovicus_MaiorSo I have a big set of changes I am going to check in later today. Why later today? Because I want one last chance to run through it to see if I really fixed everything I think I did.
So what has Ludovicus been up to?
- I have consolidated the guide parsers. Now every addon supports every tag!
- I have consolidated the event handlers. Now every addon behaves the same way in response to major game EVENT notifications.
- I have consolidated the step selection logic. Now every guide makes uniform decisions for determining the next step.
- I have consolidated the guide loading process. Now when a guide is loaded, it is setup the same and daily/weekly/monthly quests handled uniformly.
So those are the big structural changes. In theory they fix nothing except making it easier maintenance for us addon writing types. But it does mean that if a bug appears in the logic, there is only one place to fix it! As a result, a few bugs were accidentally fixed by making the logic uniform:
- The guides are now hidden uniformly when entering instances or pet battles.
- Dalies guides now reset automatically at load time.
- Loots are now counted accurately
- Automatic flight point autocomplete works (fingers crossed) uniformly
- Interfaces to secondary addons like TomTom and Grail now work across the board
But the single biggest change is I changed the the way the event processing logic and the guide update logic interacted. It used to be that events that changed quest status directly triggered guide next step selection. But Blizzard, for their own mysterious reasons, has decided to muck with it. I suspect that the game client is taking better advantage of multicore processors. Or maybe they are just being perverse. But I can no longer depend on the precise order of quest log updates, quest completion flagging, and quest NPC interactions. Worse yet, if I accept or turn in many quests in quick order, the events for the quests can be interleaved.
What to do? It turns out the solution was right under my nose. It is really the same problem as the quest loot counting problem. When you loot an item, you get multiple messages updating the status of your bags and scanning all your bags on every message is too expensive. So what you do is set a timer (for say 1/3 of a second) when you get one of these messages and reset the timer if you get another one while the timer is still active. Once the timer goes off (i.e. it has been over a 1/3 of a second since ant bag update messages came by) then count your loots.
Similarly, we need to aggregate all of the quest status modification events and punt on doing an update until things have settled down. Simple, n’est-ce pas?
Anyways, once I am satisfied this is not obviously broken, it will be available directly from GitHub at:
Oh yeah, and I started implementing a new feature. I call it “Why?”. If you open up the “Current Guide Listing” and mouse over the step texture, it will tell you “Why” that step is in that state. I added this because adding all the debug log prints to cover every eventuality resulted in huge logs that were difficult to understand. This gives you a nice concise answer for a given step.
Horde Kun-lai Summit ErrorOn load get this error, Horde, Kun-Lai Summit Date: 2013-05-07 20:38:50ID: 1Error occured in: GlobalCount: 2Message: …ceAddOnsWoWPro_LevelingWoWPro_Leveling_Parser.lua line 489: Usage: QuestPOIGetIconInfo(questID)Debug: [C]: QuestPOIGetIconInfo() …ceAddOnsWoWPro_LevelingWoWPro_Leveling_Parser.lua:489: RowUpdate() WoWProWoWPro_Broker.lua:169: rowContentUpdate() WoWProWoWPro_Broker.lua:193: WoWProWoWPro_Broker.lua:139 (tail call): ? [C]: ? [string “safecall Dispatcher[1]”]:9: [string “safecall Dispatcher[1]”]:5 (tail call): ? …ceAddOnsArchyLibsAceBucket-3.0AceBucket-3.0.lua:118: func() …sAckisRecipeListlibsAceTimer-3.0AceTimer-3.0.lua:43: …sAckisRecipeListlibsAceTimer-3.0AceTimer-3.0.lua:36Locals:None
After playing with it all dayAfter playing with it all day yesterday, it occurs to me the guide reset
behavioor is differant than before, it is resetting to the top of the
guide, like pre 2.6, but less steps are needing manually checked off,
than they did before.
I’m also experiencing theI’m also experiencing the exact errors and it does not track the quests in the GH zone.
Re2: Well that was funny didOK, the current cut should solve your problem!
Re: Good Show! Good! I am a professional guesser.
Good Show!Yep, that fixes it.
Re: Well that was funny didOh, yeah, that is a very good clue.There was code I copied from that module, and it seems I did not copy all of it.I know just where to look.
A Patch for ScrollingTry changing:
[code]
function WoWPro.UpdateGuideReal(From)
if not WoWPro.GuideFrame:IsVisible() or not GuideLoaded then return end
WoWPro:dbp(“Running: UpdateGuideReal()”)
local GID = WoWProDB.char.currentguide
local offset = WoWPro.GuideOffset
[/code]
to
[code]
function WoWPro.UpdateGuideReal(From)
if not WoWPro.GuideFrame:IsVisible() or not GuideLoaded then return end
WoWPro:dbp(“Running: UpdateGuideReal()”)
local GID = WoWProDB.char.currentguide
local offset = WoWPro.GuideOffset
WoWPro.GuideOffset = nil
[/code]
and see if that fixes it :-).
Scrolling appears fixed!I played with it a bit, scrolling seems to work, although I didn’t put it thru all the paces with guide changes, etc.The R steps are still not showing when they should, but at least I can scoll back and see what they were :)Editted to add… while scrolling does indeed appear to work. Today the guide isnt advancing. I tested this with Alliance Jade Forest (leveling) and Alliance Pet Battles (daily). This didnt happen yesterday, but perhaps it is because I didnt exit all the way out of the game when I put in the updated Wowpro_broker and wowpro_frames files? I exited to char select and updated those two files last night, played a bit, then came and posted the above. Today when I tried to use a guide, when I would manually click off the N steps it wasnt advancing. I shrugged and said to myself, “im glad the scrolling works anyway, scrolled to next N checked it off, etc. When I got to the body of the guide, it still wasnt advancing. I then tested the leveling guide to see if it was something unique to dailies, but it was misbehaving there also.
Re: Scrolling in 2.6.0Alpha2OK. I think I fixed it. But because I never saw it working right to begin with, you will have to tell me if it is working right!
Scrolling in 2.6.0Alpha2Umm, yeah, I broke it. Turns out UpdateGuide() gets an argument that I missed from the scroll bar widget to tell it how much to go forward by. Since I did not see the code being used, I removed it, because it was not compatible with my step logic update fixes.I’ll need to find another way of doing it.
Well that was funny didWell that was funny did disable all and loaded it on a new char. all fine and dandy then started to enable 1 by 1 .. no problems after i enabled all.. Then switched back to an old char and ran into the problem i posted earlier. So here is the solution.I had these enabled on my old char.wow-prowow-pro Dailieswow-pro LevelingAnd got the errors ..—29x WoWPro-2.6.0alpha2WoWPro_Parser.lua:281: attempt to index field “buff” (a nil value)WoWPro-2.6.0alpha2WoWPro_Parser.lua:281: in function “ParseQuestLine”WoWPro-2.6.0alpha2WoWPro_Parser.lua:359: in function “ParseQuests”WoWPro-2.6.0alpha2WoWPro_Parser.lua:373: in function “LoadGuideSteps”WoWPro-2.6.0alpha2WoWPro_Broker.lua:105: in function “LoadGuide”WoWProWoWPro-2.6.0alpha2.lua:330: in function <WoWProWoWPro.lua:323>Locals:self = <table> { InitLockdown = false note = <table> {} index = <table> {} zone = <table> {} CreateGuideWindowScrollbar = <func> @..WoWPro_Frames.lua:513 CreateGuideTabFrame_Rows = <func> @..WoWPro_GuideList.lua:285 NextGuide = <func> @..WoWPro_Broker.lua:111 CreateItemButton = <func> @..WoWPro_Widgets.lua:63 CreateHeading = <func> @..WoWPro_Widgets.lua:104 UpdateQuestTracker = <func> @..WoWPro_Events.lua:252 CurrentGuideFrame = <unnamed> {} Tags = <table> {} MapPoint = <func> @..WoWPro_Mapping.lua:341 SetDefaultModulePrototype = <func> @Ace3..AceAddon-3.0.lua:425 CreateSkipStepsDialog = <func> @..WoWPro_Frames.lua:650 UpdateGuide = <func> @..WoWPro_Broker.lua:131 SetDefaults = <func> @..WoWPro_Config.lua:14 Leveling = <table> {} IsEnabled = <func> @Ace3..AceAddon-3.0.lua:467 RegisterTags = <func> @..WoWPro.lua:361 LoadAllGuides = <func> @..WoWPro.lua:411 Setup_TitleRow = <func> @..WoWPro_GuideList.lua:199 RegisterMessage = <func> @Ace3..CallbackHandler-1.0.lua:118 UnregisterMessage = <func> @Ace3..CallbackHandler-1.0.lua:181 GuideList = <unnamed> {} AutoCompleteLevel = <func> @..WoWPro_Events.lua:235 UnregisterEvents = <func> @..WoWPro.lua:382 ActiveStickyCount = 0 CreateMiniMapButton = <func> @..WoWPro_Frames.lua:620 SetEnabledState = <func> @Ace3..AceAddon-3.0.lua:440 Zone2MapID = <table> {} RegisterEvents = <func> @..WoWPro.lua:372 StickyFrame = WoWPro.StickyFrame {} ResetMainFramePosition = <func> @..WoWPro_Frames.lua:15 OnEnable = <func> @..WoWPro.lua:268 Version = “2.6.0alpha2” PickQuestline = <func> @..WoWPro_Broker.lua:801 PaddingSet = <func> @..WoWPro_Frames.lua:69 DebugMode = true TitleText = <unnamed> {} AutoCompleteZone = <func> @..WoWPro_Events.lua:203 CreateGuideTabFrame = <func> @..WoWPro_GuideList.lua:368 OnInitialize = <func> @..WoWPro.lua:238 UnregisterAllEvents = <func> @Ace3..CallbackHandler-1.0.lua:202 optionalcount = 0 GuideTabFrame_RowOnClick = <func> @..WoWPro_GuideList.lua:270 NextGuideDialog = Guide Completed {} LoadNilGuide = <func> @..WoWPro_NilGuide.lua:5 stickycount = 0 actionlabels = <table> {} LogEvent = <func> @..WoWPro.lua:88 RowSet = <func> @..WoWPro_Frames.lua:318 ParsingQuestLine = “N The Battle is Won, The War Goes On|QID|27398|Z|Stormwind City|N|If you don’t have this quest, check it off and continue to the next.|FACTION|Alliance|” AutoCompleteLoot = <func> @..WoWPro_Events.lua:85 Questline = <func> @..WoWPro_Broker.lua:782 RecordTaxiLocations = <func> @..WoWPro_Events.lua:8 ShownRows = 1 mixins = <table> {} CreateStep = <func> @..WoWPro_Widgets.lua:34 GetName = <func> @Ace3..AceAddon-3.0.lua:300 FirstMapCall = true GenerateM———-I then enabled WoW-Pro World EventsAnd all was fine and error free, so there is something in leveling/dailies poiting to that module, anyways now i can play around with is only posting this since I am guessing it should be possible to disable the different modules and run only those you need.I get on with further testing 🙂 ~Mach
I downloaded the zip directlyI downloaded the zip directly from github, i still have parsing errors when selecting or trying to change the guide, im gonna post the errors i had along with the debug from wowpro. then im gonna try disable my other addons to see if anything is conflicting.——20130325/2338.001 ~ WoWPro: Patched Blizzard_GlyphUI to get rid of attempt to index global “PlayerTalentFrame” (a nil value)20130325/2338.002 ~ WoWPro_Dailies: Guide Setup complete20130325/2338.003 ~ WoWPro_Leveling: Guide Setup complete20130325/2338.004 ~ WoWPro: Enabled: Core Addon20130325/2338.005 ~ WoWPro: Enabling Leveling module…20130325/2338.006 ~ WoWPro_Leveling: Enabled220130325/2338.007 ~ WoWPro: Enabling Dailies module…20130325/2338.008 ~ WoWPro: Enabled: Dailies Module20130325/2338.009 ~ WoWPro: Registering Events: Core Addon20130325/2338.010 ~ WoWPro: PLAYER_ENTERING_WORLD()20130325/2338.011 ~ WoWPro: Event Fired: PLAYER_ENTERING_WORLD20130325/2338.012 ~ WoWPro: Setting Timer 120130325/2338.013 ~ WoWPro: QUEST_LOG_UPDATE()20130325/2338.014 ~ WoWPro: LockEvent Fired: QUEST_LOG_UPDATE20130325/2338.015 ~ WoWPro: UNIT_AURA(“player”)20130325/2338.016 ~ WoWPro: LockEvent Fired: UNIT_AURA20130325/2338.017 ~ WoWPro: Signaled for UpdateGuide20130325/2338.018 ~ WoWPro: UNIT_AURA(“player”)20130325/2338.019 ~ WoWPro: LockEvent Fired: UNIT_AURA20130325/2338.020 ~ WoWPro: QUEST_LOG_UPDATE()20130325/2338.021 ~ WoWPro: LockEvent Fired: QUEST_LOG_UPDATE20130325/2338.022 ~ WoWPro: Signaled for UpdateGuide20130325/2338.023 ~ WoWPro: Lockdown Timer expired. Return to normal20130325/2338.024 ~ WoWPro: Loading Guide: AriDee828320130325/2338.025 ~ WoWPro: Initializing Guide AriDee8283.20130325/2338.026 ~ WoWPro: Parsing Guide…20130325/2338.027 ~ WoWPro: Running: UpdateGuideReal()20130325/2338.028 ~ WoWPro: Called WoWPro:NextStep(1,1)20130325/2338.029 ~ WoWPro: Called WoWPro:NextStep(1,1)20130325/2338.030 ~ WoWPro: Called WoWPro:NextStep(2,2)20130325/2338.031 ~ WoWPro: Called WoWPro:NextStep(3,3)20130325/2338.032 ~ WoWPro: Called WoWPro:NextStep(4,4)20130325/2338.033 ~ WoWPro: Called WoWPro:NextStep(5,5)20130325/2338.034 ~ WoWPro: Called WoWPro:NextStep(6,6)20130325/2338.035 ~ WoWPro: Called WoWPro:NextStep(7,7)20130325/2338.036 ~ WoWPro: Called WoWPro:NextStep(8,8)20130325/2338.037 ~ WoWPro: Called WoWPro:NextStep(9,9)20130325/2338.038 ~ WoWPro: Called WoWPro:NextStep(10,10)20130325/2338.039 ~ WoWPro: Called WoWPro:NextStep(11,11)20130325/2338.040 ~ WoWPro: Called WoWPro:NextStep(12,12)20130325/2338.041 ~ WoWPro: Called WoWPro:NextStep(13,13)20130325/2338.042 ~ WoWPro: Called WoWPro:NextStep(14,14)20130325/2338.043 ~ WoWPro: Called WoWPro:NextStep(15,15)20130325/2338.044 ~ WoWPro: Running WoWPro:UpdateQuestTracker()20130325/2338.045 ~ WoWPro: profile.track=true action=N questtext=nil lootitem=nil20130325/2338.046 ~ WoWPro: Setting track text for N [The Battle is Won, The War Goes On] to ”20130325/2338.047 ~ WoWPro: ZONE_CHANGED_NEW_AREA()20130325/2338.048 ~ WoWPro: Event Fired: ZONE_CHANGED_NEW_AREA20130325/2338.049 ~ WoWPro: Loading Guide: EmmTillers20130325/2338.050 ~ WoWPro: Initializing Guide EmmTillers.20130325/2338.051 ~ WoWPro: Parsing Guide…20130325/2338.052 ~ WoWPro: UNIT_AURA(“player”)20130325/2338.053 ~ WoWPro: Event Fired: UNIT_AURA20130325/2338.054 ~ WoWPro_Dailies: Running: Dailies Event Handler on UNIT_AURA20130325/2339.055 ~ WoWPro: Loading Guide: LudoThunderKing20130325/2339.056 ~ WoWPro: Initializing Guide LudoThunderKing.20130325/2339.057 ~ WoWPro: Parsing Guide…20130325/2339.058 ~ WoWPro: Called WoWPro:NextStep(1,1)20130325/2339.059 ~ WoWPro: SkippedStep(1)20130325/2339.060 ~ WoWPro_Dailies: false=NextStep(2, false)20130325/2339.061 ~ WoWPro: Signaled for UpdateGuide20130325/2339.062 ~ WoWPro: Running: UpdateGuideReal()20130325/2339.063 ~ WoWPro: Called WoWPro:NextStep(1,1)20130325/2339.064 ~ WoWPro: SkippedStep(1)20130325/2339.065 ~ WoWPro_Dailies: false=NextStep(2, false)20130325/2339.066 ~ WoWPro_Dailies: Running: WoWPro.Dailies:RowUpdate()20130325/2339.067 ~ WoWPro: Called WoWPro:NextStep(2,1)20130325/2339.068 ~ WoWPro_Dailies: false=NextStep(2, false)20130325/2339.069 ~ WoWPro: Called WoWPro:NextStep(3,2)20130325/2339.070 ~ WoWPro_Dailies: false=NextStep(3, false)20130325/2339.071 ~ WoWPro: Called WoWPro:NextStep(4,3)20130325/2339.072 ~ WoWPro_Dailies: false=NextStep(4, false)20130325/2339.073 ~ WoWPro: Called WoWPro:NextStep(5,4)20130325/2339.074 ~ WoWPro_Dailies: false=NextStep(5, false)20130325/2339.075 ~ WoWPro: Called WoWPro:NextStep(6,5)20130325/2339.076 ~ WoWPro_Dailies: false=NextStep(6, false)20130325/2339.077 ~ WoWPro: Called WoWPro:NextStep(7,6)20130325/2339.078 ~ WoWPro_Dailies: false=NextStep(7, false)20130325/2339.079 ~ WoWPro: Called WoWPro:NextStep(8,7)20130325/2339.080 ~ WoWPro_Dailies: false=NextStep(8, false)20130325/2339.081 ~ WoWPro: Called WoWPro:NextStep(9,8)20130325/2339.082 ~ WoWPro_Dailies: false=NextStep(9, false)20130325/2339.083 ~ WoWPro: Called WoWPro:NextStep(10,9)20130325/2339.084 ~ WoWPro_Dailies: false=NextStep(10, false)20130325/2339.085 ~ WoWPro: Called WoWPro:NextStep(11,10)20130325/2339.086 ~ WoWPro_Dailies: false=NextStep(11, false)20130325/2339.087 ~ WoWPro: Called WoWPro:NextStep(12,11)20130325/2339.088 ~ WoWPro_Dailies: false=NextStep(12, false)20130325/2339.089 ~ WoWPro: Called WoWPro:NextStep(13,12)20130325/2339.090 ~ WoWPro_Dailies: false=NextStep(13, false)20130325/2339.091 ~ WoWPro: Called WoWPro:NextStep(14,13)20130325/2339.092 ~ WoWPro_Dailies: false=NextStep(14, false)20130325/2339.093 ~ WoWPro: Called WoWPro:NextStep(15,14)20130325/2339.094 ~ WoWPro_Dailies: false=NextStep(15, false)20130325/2339.095 ~ WoWPro: Called WoWPro:NextStep(16,15)20130325/2339.096 ~ WoWPro_Dailies: false=NextStep(16, false)20130325/2339.097 ~ WoWPro: Running WoWPro:UpdateQuestTracker()20130325/2339.098 ~ WoWPro: Loading Guide: LudoThunderKing20130325/2339.099 ~ WoWPro: Parsing Guide…20130325/2339.100 ~ WoWPro: Loading Guide: EmmAugCel20130325/2339.101 ~ WoWPro: Initializing Guide EmmAugCel.20130325/2339.102 ~ WoWPro: Parsing Guide…20130325/2339.103 ~ WoWPro: Loading Guide: EmmAugCel20130325/2339.104 ~ WoWPro: Parsing Guide…20130325/2339.105 ~ WoWPro: Loading Guide: EmmAugCel20130325/2339.106 ~ WoWPro: Parsing Guide…20130325/2339.107 ~ WoWPro: Loading Guide: EmmAugCel20130325/2339.108 ~ WoWPro: Parsing Guide…20130325/2339.109 ~ WoWPro: Loading Guide: EstGoldLotus20130325/2339.110 ~ WoWPro: Initializing Guide EstGoldLotus.20130325/2339.111 ~ WoWPro: Parsing Guide…20130325/2339.112 ~ WoWPro: Loading Guide: EstGoldLotus20130325/2339.113 ~ WoWPro: Parsing Guide…——————-Error Log:.——10x WoWPro-2.6.0alpha2WoWPro_Parser.lua:281: attempt to index field “buff” (a nil value)WoWPro-2.6.0alpha2WoWPro_Parser.lua:281: in function “ParseQuestLine”WoWPro-2.6.0alpha2WoWPro_Parser.lua:359: in function “ParseQuests”WoWPro-2.6.0alpha2WoWPro_Parser.lua:373: in function “LoadGuideSteps”WoWPro-2.6.0alpha2WoWPro_Broker.lua:105: in function “LoadGuide”WoWProWoWPro-2.6.0alpha2.lua:330: in function <WoWProWoWPro.lua:323>Locals:self = <table> { InitLockdown = false note = <table> {} index = <table> {} zone = <table> {} CreateGuideWindowScrollbar = <func> @..WoWPro_Frames.lua:513 CreateGuideTabFrame_Rows = <func> @..WoWPro_GuideList.lua:285 NextGuide = <func> @..WoWPro_Broker.lua:111 CreateItemButton = <func> @..WoWPro_Widgets.lua:63 CreateHeading = <func> @..WoWPro_Widgets.lua:104 UpdateQuestTracker = <func> @..WoWPro_Events.lua:252 CurrentGuideFrame = <unnamed> {} Tags = <table> {} MapPoint = <func> @..WoWPro_Mapping.lua:341 SetDefaultModulePrototype = <func> @Ace3..AceAddon-3.0.lua:425 CreateSkipStepsDialog = <func> @..WoWPro_Frames.lua:650 UpdateGuide = <func> @..WoWPro_Broker.lua:131 SetDefaults = <func> @..WoWPro_Config.lua:14 Leveling = <table> {} IsEnabled = <func> @Ace3..AceAddon-3.0.lua:467 RegisterTags = <func> @..WoWPro.lua:361 LoadAllGuides = <func> @..WoWPro.lua:411 Setup_TitleRow = <func> @..WoWPro_GuideList.lua:199 RegisterMessage = <func> @Ace3..CallbackHandler-1.0.lua:118 UnregisterMessage = <func> @Ace3..CallbackHandler-1.0.lua:181 GuideList = <unnamed> {} AutoCompleteLevel = <func> @..WoWPro_Events.lua:235 UnregisterEvents = <func> @..WoWPro.lua:382 ActiveStickyCount = 0 CreateMiniMapButton = <func> @..WoWPro_Frames.lua:620 SetEnabledState = <func> @Ace3..AceAddon-3.0.lua:440 Zone2MapID = <table> {} RegisterEvents = <func> @..WoWPro.lua:372 StickyFrame = WoWPro.StickyFrame {} ResetMainFramePosition = <func> @..WoWPro_Frames.lua:15 OnEnable = <func> @..WoWPro.lua:268 Version = “2.6.0alpha2” PickQuestline = <func> @..WoWPro_Broker.lua:801 PaddingSet = <func> @..WoWPro_Frames.lua:69 DebugMode = true TitleText = <unnamed> {} AutoCompleteZone = <func> @..WoWPro_Events.lua:203 CreateGuideTabFrame = <func> @..WoWPro_GuideList.lua:368 OnInitialize = <func> @..WoWPro.lua:238 UnregisterAllEvents = <func> @Ace3..CallbackHandler-1.0.lua:202 optionalcount = 0 GuideTabFrame_RowOnClick = <func> @..WoWPro_GuideList.lua:270 NextGuideDialog = Guide Completed {} LoadNilGuide = <func> @..WoWPro_NilGuide.lua:5 stickycount = 0 actionlabels = <table> {} LogEvent = <func> @..WoWPro.lua:88 RowSet = <func> @..WoWPro_Frames.lua:318 ParsingQuestLine = “N The Battle is Won, The War Goes On|QID|27398|Z|Stormwind City|N|If you don’t have this quest, check it off and continue to the next.|FACTION|Alliance|” AutoCompleteLoot = <func> @..WoWPro_Events.lua:85 Questline = <func> @..WoWPro_Broker.lua:782 RecordTaxiLocations = <func> @..WoWPro_Events.lua:8 ShownRows = 1 mixins = <table> {} CreateStep = <func> @..WoWPro_Widgets.lua:34 GetName = <func> @Ace3..AceAddon-3.0.lua:300 FirstMapCall = true GenerateM——————- ~Mach
DL’d the updateI won’t have time to play with it much tonight, but Ill try to at least do a couple of hearths or something ;). I promised to run Nax with a friend tonight before reset.I LOVE the scrolling 🙂 Although in this case if the guide was working right, it wouldnt be necesary. (except I usually want to do things out of order )
Re: Does this also fix the messed up zones like Grizzly Hills?The Horde content guides are not in the best shape. I’m leveling my own Horde toon and am slowly reworking the guides. It takes a ridiculously long time as I check every detail and then run another toon after him to check again.The error messsages you are seeing are as a result of consistency checks that the addon now does if the Grail addon is present. His addon helps point out things to fix in our guides, I find errors in his data and give him corrections. Everybody wins.By the time that 2.6.0 is cooked, many of the errors you are seeing there will be ironed out.
Re: Hey Ludo, Is the alphaYup! I ran the tillers guide yesterday error free. Version alpha2 is needed to fix the issues I saw.
Re: As of 2.6.0alpha2Hmm, please try the checked in version as of today. It is still labled alpha2, but it now has a tiny tweak to it that has started to make reloads less problematic for me at least. I will start looking at the scrolling. Never used it myself before. No wonder I broke it.
Does this also fix the messed up zones like Grizzly Hills?As others have posted, I have also seen a lot of borked guides while leveling, esp in LK content. Grizzly Hills is almost completely wrong most of the time. It either has a current ! to go get that I already have, or just plain doesn’t point me anywhere that I need to still finish. Some QID mismatches and other strange errors fly by like: The guide title [Ruuna the Blind] and the quest title [Tactical Clemency] do not match.The npc qid [12422] and the quest qid [12425] do not match. It seems almost like someone added something to offset a whole bunch of qids which broke the remainder of the guide in the zone.
As of 2.6.0alphabI verified in game that I had loaded the new version. (because sometimes Im talented like that)When you do a loading screen reset (i.e. reload), steps you checked off manually (right or left click – i checked in case it made a differance) do not stay checked. Thus putting the pet battles guide back at step 1, if you havent yet done the Trixxy quest (first one for rank 1 is the QID i tied to all the N steps at the beginning) This will be particularly troublesome when porting from Stormwind to Mt Hyjal at the bitting on the guide. Since the pet battle guides count on you changing continents a few times, this is annoying. edited to add: Also when you have a reload (continent change) the TomTom arrow stays mapped to what it should be. only the steps in the guide window are reset.The scrolling inside the guide window doesnt work. I tested this across multiple guides in the dailies and the leveling guides. I checked and unchecked scroll mode, resize, and resize handle to see if made a differance. Nothing I tried let me scroll thru the guide.In the pet battles guide, it is stil skipping R steps and coming back to them after you accept the quest (thus completing the A step)For example (see guide code below), you manually check off (N) Sack of Pet Supplies, and the guide jumps immediately to (A) Brok (unless on Rank 1, where it jumps to (A) Grand Master Trixxy. Once you accept (A) Brok, it jumps back so that (R) Stormwind is the first visable step, you manuallly check that off and then the (R) Mount Hyjal step moves to the top step. Manually check that off and (C)Brok is now the next step. If you chose to go ahead and do (C)Brok (without manually checking off the (R) steps) the R step stays mapped to the TomTom arrow, but the guide moves to the next visable step (then because the scrolling is broken, you cant just scroll back and check it off, you have to open to “current guide” and check it off there) I have since discovered that if you check and then uncheck an (R) step, it will move the “crazy arrow” to the correct step.N Sack of Pet Supplies|QID|31909|N|S…R Stormwind|QID|31909|M|76.16,18.6…|RANK|1|…R Mount Hyjal|QID|31972|M|61.4,32.8…|RANK|2|…A Brok|QID|31972|M|61.4,33|Z|Mount…|RANK|2|…C Brok|QID|31972|M|61.4,33|Z|Mount…|RANK|2|…T Brok|QID|31972|M|61.4,33|Z|Mount…|RANK|2|…R Winterspring|QID|31909|M|65.63,64…|RANK|1|…A Grand Master Trixxy|QID|31909|M|6…|RANK|1|…— end code excerpt —Im certain there was something else I wanted to add… but Im not able to remember it. May add more.
Hey Ludo,
Is the alphaHey Ludo, Is the alpha ready for further testing? sorry if im pestering you with alot of questions I am just eager to test, and ofc. eager to use the new guides :)I fetched the latest this morning, but i still had errors when trying to load/change guide.Ow and i just read that you have been empaneled, so i guess that explains alot 🙂 and then its easter as well, wish you and yours a happy and awesome easter!~Mach
Re: Alliance Zangarmarsh bug OK. I reproduced the bug on the Tiller’s guide just by overcooking enough quest food for a few days.Now the guide is completly stuck!Your warning is now fixed in the beta version. I corrected a ton of spelling and mismatched case problems yesterday.
WoWPro: Invalid Z tag in:R Stormwind|QID|31909|M|76.16,18.69|Z|SOK, I now have an explanation for:WoWPro: Invalid Z tag in:R Stormwind|QID|31909|M|76.16,18.69|Z|StormwindANK|1|TakeAnytime you print a string with an |R in it, the string gets interpreted as being an end of UI color change sequence.So the dammed print function is eating the |R. The zone name should be “Stormwind City”.I noticed that the error log messages versus the internal version stored in the .LUA file were not the same!
Re: reset (really reload)Grand! For future reference, this is the way I see the world:Reload: This happens when you first enter WoW or anytime you see the loading screen.The Addon should put you right back at the same step, unless you changed zones and you completed the current step as a result.The Addon will do some set of adjustments of step completions to deal with periodic quests.A reload can be manually invoked by doing the /reload command at the chat prompt!Guide Reset: This happens when you select the menu entry to reset the current guide. All step completion and skipping state is dropped and the guide is re-evaluated from scratch.Addon Reset: This happens when you press the big red button in the configuration panel. All step completion information and addon state is wiped, bringing it to full defaults.So does the bad thing happen when you do “/reload“?
resetThis was referring to the reset that occurs when you swich continents via portal/boat/zep
Re: The guide reset is differantOK. This is good. It is supposed to reset completed steps back to uncompleted if the server says they are not done (for periodic quests). It is also supposed to remember skipped quests and leave them skipped.Now just to clarify: are you talking about the guide “reload” at the start of the day or a “reset” done by hand on the guide?
The guide reset is differantAfter playing with it all day yesterday, it occurs to me the guide reset behavioor is differant than before, it is resetting to the top of the guide, like pre 2.6, but less steps are needing manually checked off, than they did before. I used the QID for the first RANK 1 quest(31909) in the N (notes) steps and I used to have to check those off each time I changed continents, now I only have to check off the steps I manually skipped. (I usually skip the lvl 2 and 3 fights, but do the rest of the low level fights so I have it set to rank 3.)
Re: All errors were seen in theWell then! I guess I better get them in, stat!
All errors were seen in theAll errors were seen in the pet battle guides (the one about stormwind obviously only in the alliance). The rest in both.
Re: More from me :)Which guides were you in when you saw each of the errors?
More from me :)Ok, Ive done a bit of testing now and noticed the followingThe good ( FIXED YAY!!!):Rank Tags now work in the Dailies moduleDailies guide hides during pet battlesThe Bad (NEW): I can no longer scroll thru my guide (in the guide window). The scroll bar is still there, the box in it moves, but the text does not changeParser isnt parsing these two lines right, (this may have been bad before, but the improved error checking made it stand out, error message is new, see the last two lines)20130322/0858.001 ~ WoWPro: Patched Blizzard_GlyphUI to get rid of attempt to index global “PlayerTalentFrame” (a nil value)20130322/0858.002 ~ WoWPro: PLAYER_ENTERING_WORLD()20130322/0858.003 ~ WoWPro: QUEST_LOG_UPDATE()20130322/0858.004 ~ WoWPro: UPDATE_BINDINGS()20130322/0858.005 ~ WoWPro: QUEST_LOG_UPDATE()20130322/0858.006 ~ WoWPro: Invalid Z tag in:R Stormwind|QID|31909|M|76.16,18.69|Z|StormwindANK|1|Take the Portal to Mt Hyjal.|20130322/0858.007 ~ WoWPro: Invalid Z tag in:R Cataclysm Portals|QID|31974|M|76,18|Z|StormwindANK|1|N|Use the portals or take a long flight.|Yes, I have double checked the lines in the guide and it does say “|Z|Stormwind|RANK|1|”, I also tried deleting the misparsed 3 char and retyping them. no love.The Ugly (OLD):guide resets when you switch continents (via portal/boat/etc)guide skips the “R” steps, but now I can’t easily scroll back to fix them since the scroll feature appears brokenIm going to go ahead and post my pet battle guides, but without the R steps working right, its not as useful as it could be.
Thanks~I’m really looking forward to trying out your changes. This week has been hectic as there is a curriculum fair (science projects and stuff) that two of my kids had to have presentations for tonight. It has meant some very late nights this week (and without WoW). I’m happy to say my 10 year old turned her project in yesterday and my 12 year old took hers today all finished, (except a group video that they made friday but the teacher says has to be redone for some inappropriate language). Its amazing how they can’t seem to do anything until I sit beside them and spell out each step. 🙁 … Hummm. maybe thats why I write guides, Its practice for RL. Anyway, my point is, I’ve installed the update and tonight I will check out the changes and hopefully tomorrow post my PetBattle guides officially too. I have been holding off because the skipped travel steps made them less useful. (/sigh and I still haven’t beaten all of the wandering pandaran spirits).
Ah good it pleases me thatAh good it pleases me that you atleast could use some of the wall(s) of text in the end after all ^^ Again thanks for your time, I really love this addon 🙂
Re: I dont use the inbuilt, and INo worries! I can see from the log trace that there seems to be a bug where you currrently have the tillers guide selected, it finds nothing to do and runs off and loads the “Nil” guide instead. There are two things for me to fix: the next guide selection logic is messed up as a result of my merging code from 7 placesthe “nil” guide needs to tell you why you are there!
There is got around to do theThere is got around to do the wowpro log. and sorry about the lenght of this reply..here is the output from that.——-20130320/1300.002 ~ WoWPro: Log Reset from UI20130320/1300.003 ~ WoWPro: CHAT_MSG_SYSTEM(“[Surpompen] has come online.”, “”, “”, “”, “”, “”, 0, 0, “”, 0, 206, nil, 0, false, false)20130320/1300.004 ~ WoWPro: Event Fired: CHAT_MSG_SYSTEM20130320/1300.005 ~ WoWPro: Test Load of All Guides20130320/1300.006 ~ WoWPro: Test Loading AriDee828320130320/1300.007 ~ WoWPro: Loading Guide: AriDee828320130320/1300.008 ~ WoWPro: Parsing Guide…20130320/1300.009 ~ WoWPro: Loading Guide: LudoThunderKing20130320/1300.010 ~ WoWPro: Initializing Guide LudoThunderKing.20130320/1300.011 ~ WoWPro: Parsing Guide…20130320/1300.012 ~ WoWPro: Loading Guide: EmmTillers20130320/1300.013 ~ WoWPro: Resetting Guide EmmTillers due to upgrade. Forgetting skipped steps.20130320/1300.014 ~ WoWPro: Parsing Guide…20130320/1300.015 ~ WoWPro: Loading Guide: EmmTillers20130320/1300.016 ~ WoWPro: Parsing Guide…20130320/1301.017 ~ WoWPro: CHAT_MSG_SYSTEM(“[Surpompen] has gone offline.”, “”, “”, “”, “”, “”, 0, 0, “”, 0, 327, nil, 0, false, false)20130320/1301.018 ~ WoWPro: Event Fired: CHAT_MSG_SYSTEM20130320/1301.019 ~ WoWPro_Dailies: Running: Dailies Event Handler on CHAT_MSG_SYSTEM20130320/1302.020 ~ WoWPro: CHAT_MSG_SYSTEM(“[Surpompen] has come online.”, “”, “”, “”, “”, “”, 0, 0, “”, 0, 440, nil, 0, false, false)20130320/1302.021 ~ WoWPro: Event Fired: CHAT_MSG_SYSTEM20130320/1302.022 ~ WoWPro_Dailies: Running: Dailies Event Handler on CHAT_MSG_SYSTEM20130320/1303.023 ~ WoWPro: CHAT_MSG_SYSTEM(“[Surpompen] has gone offline.”, “”, “”, “”, “”, “”, 0, 0, “”, 0, 537, nil, 0, false, false)20130320/1303.024 ~ WoWPro: Event Fired: CHAT_MSG_SYSTEM20130320/1303.025 ~ WoWPro_Dailies: Running: Dailies Event Handler on CHAT_MSG_SYSTEM20130320/1303.026 ~ WoWPro: Signaled for UpdateGuide20130320/1303.027 ~ WoWPro: Running: UpdateGuideReal()20130320/1303.028 ~ WoWPro: Called WoWPro:NextStep(1,1)20130320/1303.029 ~ WoWPro_Dailies: false=NextStep(1, false)20130320/1303.030 ~ WoWPro_Dailies: Running: WoWPro.Dailies:RowUpdate()20130320/1303.031 ~ WoWPro: Called WoWPro:NextStep(1,1)20130320/1303.032 ~ WoWPro_Dailies: false=NextStep(1, false)20130320/1303.033 ~ WoWPro: Called WoWPro:NextStep(2,2)20130320/1303.034 ~ WoWPro_Dailies: false=NextStep(2, false)20130320/1303.035 ~ WoWPro: Called WoWPro:NextStep(3,3)20130320/1303.036 ~ WoWPro_Dailies: false=NextStep(3, false)20130320/1303.037 ~ WoWPro: Called WoWPro:NextStep(4,4)20130320/1303.038 ~ WoWPro_Dailies: false=NextStep(4, false)20130320/1303.039 ~ WoWPro: Called WoWPro:NextStep(5,5)20130320/1303.040 ~ WoWPro_Dailies: false=NextStep(5, false)20130320/1303.041 ~ WoWPro: Called WoWPro:NextStep(6,6)20130320/1303.042 ~ WoWPro_Dailies: false=NextStep(6, false)20130320/1303.043 ~ WoWPro: Called WoWPro:NextStep(7,7)20130320/1303.044 ~ WoWPro_Dailies: false=NextStep(7, false)20130320/1303.045 ~ WoWPro: Called WoWPro:NextStep(8,8)20130320/1303.046 ~ WoWPro_Dailies: false=NextStep(8, false)20130320/1303.047 ~ WoWPro: Called WoWPro:NextStep(9,9)20130320/1303.048 ~ WoWPro_Dailies: false=NextStep(9, false)20130320/1303.049 ~ WoWPro: Called WoWPro:NextStep(10,10)20130320/1303.050 ~ WoWPro_Dailies: false=NextStep(10, false)20130320/1303.051 ~ WoWPro: Called WoWPro:NextStep(11,11)20130320/1303.052 ~ WoWPro_Dailies: false=NextStep(11, false)20130320/1303.053 ~ WoWPro: Called WoWPro:NextStep(12,12)20130320/1303.054 ~ WoWPro_Dailies: false=NextStep(12, false)20130320/1303.055 ~ WoWPro: Called WoWPro:NextStep(13,13)20130320/1303.056 ~ WoWPro_Dailies: false=NextStep(13, false)20130320/1303.057 ~ WoWPro: Called WoWPro:NextStep(14,14)20130320/1303.058 ~ WoWPro_Dailies: false=NextStep(14, false)20130320/1303.059 ~ WoWPro: Called WoWPro:NextStep(15,15)20130320/1303.060 ~ WoWPro_Dailies: false=NextStep(15, false)20130320/1303.061 ~ WoWPro: Running WoWPro:UpdateQuestTracker()20130320/1303.062 ~ WoWPro: profile.track=true action=N questtext=nil lootitem=nil20130320/1303.063 ~ WoWPro: Setting track text for N [Work in progress!] to ”20130320/1303.064 ~ WoWPro: Running: UpdateGuideReal()20130320/1303.065 ~ WoWPro: Called WoWPro:NextStep(1,1)20130320/1303.066 ~ WoWPro_Dailies: false=NextStep(1, false)20130320/1303.067 ~ WoWPro_Dailies: Running: WoWPro.Dailies:RowUpdate()20130320/1303.068 ~ WoWPro: Called WoWPro:NextStep(1,1)20130320/1303.069 ~ WoWPro_Dailies: false=NextStep(1, false)20130320/1303.070 ~ WoWPro: Called WoWPro:NextStep(2,2)20130320/1303.071 ~ WoWPro_Dailies: false=NextStep(2, false)20130320/1303.072 ~ WoWPro: Called WoWPro:NextStep(3,3)20130320/1303.073 ~ WoWPro_Dailies: false=NextStep(3, false)20130320/1303.074 ~ WoWPro: Called WoWPro:NextStep(4,4)20130320/1303.075 ~ WoWPro_Dailies: false=NextStep(4, false)20130320/1303.076 ~ WoWPro: Called WoWPro:NextStep(5,5)20130320/1303.077 ~ WoWPro_Dailies: false=NextStep(5, false)20130320/1303.078 ~ WoWPro: Called WoWPro:NextStep(6,6)20130320/1303.079 ~ WoWPro_Dailies: false=NextStep(6, false)20130320/1303.080 ~ WoWPro: Called WoWPro:NextStep(7,7)20130320/1303.081 ~ WoWPro_Dailies: false=NextStep(7, false)20130320/1303.082 ~ WoWPro: Called WoWPro:NextStep(8,8)20130320/1303.083 ~ WoWPro_Dailies: false=NextStep(8, false)20130320/1303.084 ~ WoWPro: Called WoWPro:NextStep(9,9)20130320/1303.085 ~ WoWPro_Dailies: false=NextStep(9, false)20130320/1303.086 ~ WoWPro: Called WoWPro:NextStep(10,10)20130320/1303.087 ~ WoWPro_Dailies: false=NextStep(10, false)20130320/1303.088 ~ WoWPro: Called WoWPro:NextStep(11,11)20130320/1303.089 ~ WoWPro_Dailies: false=NextStep(11, false)20130320/1303.090 ~ WoWPro: Called WoWPro:NextStep(12,12)20130320/1303.091 ~ WoWPro_Dailies: false=NextStep(12, false)20130320/1303.092 ~ WoWPro: Called WoWPro:NextStep(13,13)20130320/1303.093 ~ WoWPro_Dailies: false=NextStep(13, false)20130320/1303.094 ~ WoWPro: Called WoWPro:NextStep(14,14)20130320/1303.095 ~ WoWPro_Dailies: false=NextStep(14, false)20130320/1303.096 ~ WoWPro: Called WoWPro:NextStep(15,15)20130320/1303.097 ~ WoWPro_Dailies: false=NextStep(15, false)20130320/1303.098 ~ WoWPro: Running WoWPro:UpdateQuestTracker()20130320/1303.099 ~ WoWPro: profile.track=true action=N questtext=nil lootitem=nil20130320/1303.100 ~ WoWPro: Setting track text for N [Work in progress!] to ”20130320/1303.101 ~ WoWPro: Called WoWPro:NextStep(1,1)20130320/1303.102 ~ WoWPro_Dailies: false=NextStep(2, false)20130320/1303.103 ~ WoWPro: Signaled for UpdateGuide20130320/1303.104 ~ WoWPro: Running: UpdateGuideReal()20130320/1303.105 ~ WoWPro: Called WoWPro:NextStep(1,1)20130320/1303.106 ~ WoWPro_Dailies: false=NextStep(2, false)20130320/1303.107 ~ WoWPro_Dailies: Running: WoWPro.Dailies:RowUpdate()20130320/1303.108 ~ WoWPro: Called WoWPro:NextStep(2,1)20130320/1303.109 ~ WoWPro_Dailies: false=NextStep(2, false)20130320/1303.110 ~ WoWPro: Called WoWPro:NextStep(3,2)20130320/1303.111 ~ WoWPro_Dailies: false=NextStep(3, false)20130320/1303.112 ~ WoWPro: Called WoWPro:NextStep(4,3)20130320/1303.113 ~ WoWPro_Dailies: false=NextStep(4, false)20130320/1303.114 ~ WoWPro: Called WoWPro:NextStep(5,4)20130320/1303.115 ~ WoWPro_Dailies: false=NextStep(5, false)20130320/1303.116 ~ WoWPro: Called WoWPro:NextStep(6,5)20130320/1303.117 ~ WoWPro_Dailies: false=NextStep(6, false)20130320/1303.118 ~ WoWPro: Called WoWPro:NextStep(7,6)20130320/1303.119 ~ WoWPro_Dailies: false=NextStep(7, false)20130320/1303.120 ~ WoWPro: Called WoWPro:NextStep(8,7)20130320/1303.121 ~ WoWPro_Dailies: false=NextStep(8, false)20130320/1303.122 ~ WoWPro: Called WoWPro:NextStep(9,8)20130320/1303.123 ~ WoWPro_Dailies: false=NextStep(9, false)20130320/1303.124 ~ WoWPro: Called WoWPro:NextStep(10,9)20130320/1303.125 ~ WoWPro_Dailies: false=NextStep(10, false)20130320/1303.126 ~ WoWPro: Called WoWPro:NextStep(11,10)20130320/1303.127 ~ WoWPro_Dailies: false=NextStep(11, false)20130320/1303.128 ~ WoWPro: Called WoWPro:NextStep(12,11)20130320/1303.129 ~ WoWPro_Dailies: false=NextStep(12, false)20130320/1303.130 ~ WoWPro: Called WoWPro:NextStep(13,12)20130320/1303.131 ~ WoWPro_Dailies: false=NextStep(13, false)20130320/1303.132 ~ WoWPro: Called WoWPro:NextStep(14,13)20130320/1303.133 ~ WoWPro_Dailies: false=NextStep(14, false)20130320/1303.134 ~ WoWPro: Called WoWPro:NextStep(15,14)20130320/1303.135 ~ WoWPro_Dailies: false=NextStep(15, false)20130320/1303.136 ~ WoWPro: Called WoWPro:NextStep(16,15)20130320/1303.137 ~ WoWPro_Dailies: false=NextStep(16, false)20130320/1303.138 ~ WoWPro: Running WoWPro:UpdateQuestTracker()20130320/1303.139 ~ WoWPro: No guide specified, loading NilGuide.20130320/1303.140 ~ WoWPro: Running: UpdateGuideReal()20130320/1303.141 ~ WoWPro: Suppresssed guide update. No guide.20130320/1304.142 ~ WoWPro: Loading Guide: LudoThunderKing20130320/1304.143 ~ WoWPro: Parsing Guide…20130320/1304.144 ~ WoWPro: Loading Guide: LudoThunderKing20130320/1304.145 ~ WoWPro: Parsing Guide…20130320/1304.146 ~ WoWPro: Loading Guide: EmmShadoPan20130320/1304.147 ~ WoWPro: Parsing Guide…——————No errors there it seems anyhow when i select a guide nothing pops up in the guide window. From my bugsack addon this is what it spits out.—————-31x WoWPro-2.6.0alpha1WoWPro_Parser.lua:274: attempt to index field “buff” (a nil value)WoWPro-2.6.0alpha1WoWPro_Parser.lua:274: in function “ParseQuestLine”WoWPro-2.6.0alpha1WoWPro_Parser.lua:349: in function “ParseQuests”WoWPro-2.6.0alpha1WoWPro_Parser.lua:362: in function “LoadGuideSteps”WoWPro-2.6.0alpha1WoWPro_Broker.lua:101: in function “LoadGuide”WoWProWoWPro-2.6.0alpha1.lua:326: in function <WoWProWoWPro.lua:319>Locals:self = <table> { InitLockdown = false note = <table> {} index = <table> {} zone = <table> {} CreateGuideWindowScrollbar = <func> @..WoWPro_Frames.lua:513 CreateGuideTabFrame_Rows = <func> @..WoWPro_GuideList.lua:285 NextGuide = <func> @..WoWPro_Broker.lua:107 CreateItemButton = <func> @..WoWPro_Widgets.lua:63 CreateHeading = <func> @..WoWPro_Widgets.lua:104 UpdateQuestTracker = <func> @..WoWPro_Events.lua:252 CurrentGuideFrame = <unnamed> {} Tags = <table> {} MapPoint = <func> @..WoWPro_Mapping.lua:341 SetDefaultModulePrototype = <func> @Ace3..AceAddon-3.0.lua:425 CreateSkipStepsDialog = <func> @..WoWPro_Frames.lua:650 UpdateGuide = <func> @..WoWPro_Broker.lua:124 SetDefaults = <func> @..WoWPro_Config.lua:14 Leveling = <table> {} IsEnabled = <func> @Ace3..AceAddon-3.0.lua:467 RegisterTags = <func> @..WoWPro.lua:357 LoadAllGuides = <func> @..WoWPro.lua:407 Setup_TitleRow = <func> @..WoWPro_GuideList.lua:199 RegisterMessage = <func> @Ace3..CallbackHandler-1.0.lua:118 UnregisterMessage = <func> @Ace3..CallbackHandler-1.0.lua:181 GuideList = <unnamed> {} AutoCompleteLevel = <func> @..WoWPro_Events.lua:235 UnregisterEvents = <func> @..WoWPro.lua:378 ActiveStickyCount = 0 CreateMiniMapButton = <func> @..WoWPro_Frames.lua:620 SetEnabledState = <func> @Ace3..AceAddon-3.0.lua:440 Zone2MapID = <table> {} RegisterEvents = <func> @..WoWPro.lua:368 StickyFrame = WoWPro.StickyFrame {} ResetMainFramePosition = <func> @..WoWPro_Frames.lua:15 OnEnable = <func> @..WoWPro.lua:264 Version = “2.6.0alpha1” PickQuestline = <func> @..WoWPro_Broker.lua:756 PaddingSet = <func> @..WoWPro_Frames.lua:69 DebugMode = false TitleText = <unnamed> {} AutoCompleteZone = <func> @..WoWPro_Events.lua:203 CreateGuideTabFrame = <func> @..WoWPro_GuideList.lua:368 OnInitialize = <func> @..WoWPro.lua:238 UnregisterAllEvents = <func> @Ace3..CallbackHandler-1.0.lua:202 GuideTabFrame_RowOnClick = <func> @..WoWPro_GuideList.lua:270 NextGuideDialog = Guide Completed {} LoadNilGuide = <func> @..WoWPro_NilGuide.lua:5 stickycount = 0 actionlabels = <table> {} LogEvent = <func> @..WoWPro.lua:88 RowSet = <func> @..WoWPro_Frames.lua:318 optionalcount = 0 AutoCompleteLoot = <func> @..WoWPro_Events.lua:85 Questline = <func> @..WoWPro_Broker.lua:737 RecordTaxiLocations = <func> @..WoWPro_Events.lua:8 ShownRows = 1 mixins = <table> {} CreateStep = <func> @..WoWPro_Widgets.lua:34 GetName = <func> @Ace3..AceAddon-3.0.lua:300 FirstMapCall = true GenerateMapCache = <func> @..WoWPro_Zones.lua:2994 CreateGuideList = <func> @..WoWPro_GuideList.lua:8 name = “WoW—————Again im fairly sure bugsack grabs the addon version from the wowpro.toc file and i’ve tripple checked that i have the addon installed correctly, still same thing happens :/ ~Mach
I dont use the inbuilt, and II dont use the inbuilt, and I am actually sorry that i did not tell you that when i posted the error msg in the first place, i use bugsack and it seems to be grabbing the version number from toc file? atleast i’ve seen it write in similar way with other addon errors.I saw this abit late now, and are on my way to bed but if you want i can run the inbuilt script from wowpro as i should’ve done in the first place, but it’ll have to wait until the servers are back up tomorrow.Thanks for your time and sorry to have wasted some of it posting from another source than you originally asked me todo.———~Mach
Re: Hei, First thanks for takingOK. Slick script there. But something is up.If you used the script, then there should be no way that it would know the version number. The version number shows up as part of the zip file.Is there a possibility that you have both the zip file and the script file installed at the same time?
Hei,
First thanks for takingHei,First thanks for taking the time to respond that fast here is what i did yesterday and today when installing, and i’ve just reinstalled again to see if it was me being a total newb :pI’ve had since the start of jan 2013 made a batfile for updating directly from github and into the addon dir, here is the batch i use for that.—@cd D:gamesaddons_manualWoW-Pro-GuidesWoW-Pro-Guides@git fetch –all@git reset –hard origin/masterECHO ————————–@rmdir /s /q D:GamesWoWInterfaceaddonsWoWPro@rmdir /s /q D:GamesWoWInterfaceaddonsWoWPro_Achievements@rmdir /s /q D:GamesWoWInterfaceaddonsWoWPro_Dailies@rmdir /s /q D:GamesWoWInterfaceaddonsWoWPro_Leveling@rmdir /s /q D:GamesWoWInterfaceaddonsWoWPro_Profession@rmdir /s /q D:GamesWoWInterfaceaddonsWoWPro_WorldEvents@xcopy /s /i /Q D:Gamesaddons_manualWoW-Pro-GuidesWoW-Pro-GuidesWoWPro D:GamesWoWInterfaceaddonsWoWPro@xcopy /s /i /Q D:Gamesaddons_manualWoW-Pro-GuidesWoW-Pro-GuidesWoWPro_Achievements D:GamesWoWInterfaceaddonsWoWPro_Achievements@xcopy /s /i /Q D:Gamesaddons_manualWoW-Pro-GuidesWoW-Pro-GuidesWoWPro_Dailies D:GamesWoWInterfaceaddonsWoWPro_Dailies@xcopy /s /i /Q D:Gamesaddons_manualWoW-Pro-GuidesWoW-Pro-GuidesWoWPro_Leveling D:GamesWoWInterfaceaddonsWoWPro_Leveling@xcopy /s /i /Q D:Gamesaddons_manualWoW-Pro-GuidesWoW-Pro-GuidesWoWPro_Profession D:GamesWoWInterfaceaddonsWoWPro_Profession@xcopy /s /i /Q D:Gamesaddons_manualWoW-Pro-GuidesWoW-Pro-GuidesWoWPro_WorldEvents D:GamesWoWInterfaceaddonsWoWPro_WorldEvents—So i should’ve deleted and made sure everything was fine and dandy, anyways since it was’nt yesterday i grabbed the zip you included in the post above and did the step as follows.1. unzip 2. copy . * WoWPro* WoWPro_Achievements* WoWPro_Dailies* WoWPro_Leveling* WoWPro_Profession* WoWPro_WorldEventsInto my interfance/addons/ dirI then logged on and grabbed the errors i posted in the reply above. ~Mach
Re: on the initial load andI think you have managed to install the addon set incorrectly. The path “WoWPro-2.6.0alpha1WoWPro_Parser.lua” is abnormal. There should be a “WoWPro” directory, a “WowPro_Leveling” directrory and they should not be inside any other directory like “WoWPro-2.6.0alpha1”, but directly in the “AddOns” directory. Please try re-instaling!
on the initial load andon the initial load and entering wow this is what i get —————————————————————————————————————————WoWPro-2.6.0alpha1WoWPro_Parser.lua:274: attempt to index field “buff” (a nil value)WoWPro-2.6.0alpha1WoWPro_Parser.lua:274: in function “ParseQuestLine”WoWPro-2.6.0alpha1WoWPro_Parser.lua:349: in function “ParseQuests”WoWPro-2.6.0alpha1WoWPro_Parser.lua:362: in function “LoadGuideSteps”WoWPro-2.6.0alpha1WoWPro_Broker.lua:101: in function “LoadGuide”WoWProWoWPro-2.6.0alpha1.lua:326: in function <WoWProWoWPro.lua:319>Locals:self = <table> { InitLockdown = false note = <table> {} index = <table> {} zone = <table> {} CreateGuideWindowScrollbar = <func> @..WoWPro_Frames.lua:513 CreateGuideTabFrame_Rows = <func> @..WoWPro_GuideList.lua:285 NextGuide = <func> @..WoWPro_Broker.lua:107 CreateItemButton = <func> @..WoWPro_Widgets.lua:63 CreateHeading = <func> @..WoWPro_Widgets.lua:104 UpdateQuestTracker = <func> @..WoWPro_Events.lua:252 CurrentGuideFrame = <unnamed> {} Tags = <table> {} MapPoint = <func> @..WoWPro_Mapping.lua:341 SetDefaultModulePrototype = <func> @Ace3..AceAddon-3.0.lua:425 CreateSkipStepsDialog = <func> @..WoWPro_Frames.lua:650 UpdateGuide = <func> @..WoWPro_Broker.lua:124 SetDefaults = <func> @..WoWPro_Config.lua:14 Leveling = <table> {} IsEnabled = <func> @Ace3..AceAddon-3.0.lua:467 RegisterTags = <func> @..WoWPro.lua:357 LoadAllGuides = <func> @..WoWPro.lua:407 Setup_TitleRow = <func> @..WoWPro_GuideList.lua:199 RegisterMessage = <func> @Ace3..CallbackHandler-1.0.lua:118 UnregisterMessage = <func> @Ace3..CallbackHandler-1.0.lua:181 GuideList = <unnamed> {} AutoCompleteLevel = <func> @..WoWPro_Events.lua:235 UnregisterEvents = <func> @..WoWPro.lua:378 ActiveStickyCount = 0 CreateMiniMapButton = <func> @..WoWPro_Frames.lua:620 SetEnabledState = <func> @Ace3..AceAddon-3.0.lua:440 Zone2MapID = <table> {} RegisterEvents = <func> @..WoWPro.lua:368 StickyFrame = WoWPro.StickyFrame {} ResetMainFramePosition = <func> @..WoWPro_Frames.lua:15 OnEnable = <func> @..WoWPro.lua:264 Version = “2.6.0alpha1” PickQuestline = <func> @..WoWPro_Broker.lua:756 PaddingSet = <func> @..WoWPro_Frames.lua:69 DebugMode = false TitleText = <unnamed> {} AutoCompleteZone = <func> @..WoWPro_Events.lua:203 CreateGuideTabFrame = <func> @..WoWPro_GuideList.lua:368 OnInitialize = <func> @..WoWPro.lua:238 UnregisterAllEvents = <func> @Ace3..CallbackHandler-1.0.lua:202 GuideTabFrame_RowOnClick = <func> @..WoWPro_GuideList.lua:270 NextGuideDialog = Guide Completed {} LoadNilGuide = <func> @..WoWPro_NilGuide.lua:5 stickycount = 0 actionlabels = <table> {} LogEvent = <func> @..WoWPro.lua:88 RowSet = <func> @..WoWPro_Frames.lua:318 optionalcount = 0 AutoCompleteLoot = <func> @..WoWPro_Events.lua:85 Questline = <func> @..WoWPro_Broker.lua:737 RecordTaxiLocations = <func> @..WoWPro_Events.lua:8 ShownRows = 1 mixins = <table> {} CreateStep = <func> @..WoWPro_Widgets.lua:34 GetName = <func> @Ace3..AceAddon-3.0.lua:300 FirstMapCall = true GenerateMapCache = <func> @..WoWPro_Zones.lua:2994 CreateGuideList = <func> @..WoWPro_GuideList.lua:8 name = “WoW————————————Turning debug on and trying to change / load new guide ——>————————————2x WoWPro-2.6.0alpha1WoWPro_Parser.lua:274: attempt to index field “buff” (a nil value)WoWPro-2.6.0alpha1WoWPro_Parser.lua:274: in function “ParseQuestLine”WoWPro-2.6.0alpha1WoWPro_Parser.lua:349: in function “ParseQuests”WoWPro-2.6.0alpha1WoWPro_Parser.lua:362: in function “LoadGuideSteps”WoWPro-2.6.0alpha1WoWPro_Broker.lua:101: in function “LoadGuide”WoWProWoWPro-2.6.0alpha1.lua:326: in function <WoWProWoWPro.lua:319>Locals:self = <table> { InitLockdown = false note = <table> {} index = <table> {} zone = <table> {} CreateGuideWindowScrollbar = <func> @..WoWPro_Frames.lua:513 CreateGuideTabFrame_Rows = <func> @..WoWPro_GuideList.lua:285 NextGuide = <func> @..WoWPro_Broker.lua:107 CreateItemButton = <func> @..WoWPro_Widgets.lua:63 CreateHeading = <func> @..WoWPro_Widgets.lua:104 UpdateQuestTracker = <func> @..WoWPro_Events.lua:252 CurrentGuideFrame = <unnamed> {} Tags = <table> {} MapPoint = <func> @..WoWPro_Mapping.lua:341 SetDefaultModulePrototype = <func> @Ace3..AceAddon-3.0.lua:425 CreateSkipStepsDialog = <func> @..WoWPro_Frames.lua:650 UpdateGuide = <func> @..WoWPro_Broker.lua:124 SetDefaults = <func> @..WoWPro_Config.lua:14 Leveling = <table> {} IsEnabled = <func> @Ace3..AceAddon-3.0.lua:467 RegisterTags = <func> @..WoWPro.lua:357 LoadAllGuides = <func> @..WoWPro.lua:407 Setup_TitleRow = <func> @..WoWPro_GuideList.lua:199 RegisterMessage = <func> @Ace3..CallbackHandler-1.0.lua:118 UnregisterMessage = <func> @Ace3..CallbackHandler-1.0.lua:181 GuideList = <unnamed> {} AutoCompleteLevel = <func> @..WoWPro_Events.lua:235 UnregisterEvents = <func> @..WoWPro.lua:378 ActiveStickyCount = 0 CreateMiniMapButton = <func> @..WoWPro_Frames.lua:620 SetEnabledState = <func> @Ace3..AceAddon-3.0.lua:440 Zone2MapID = <table> {} RegisterEvents = <func> @..WoWPro.lua:368 StickyFrame = WoWPro.StickyFrame {} ResetMainFramePosition = <func> @..WoWPro_Frames.lua:15 OnEnable = <func> @..WoWPro.lua:264 Version = “2.6.0alpha1” PickQuestline = <func> @..WoWPro_Broker.lua:756 PaddingSet = <func> @..WoWPro_Frames.lua:69 DebugMode = false TitleText = <unnamed> {} AutoCompleteZone = <func> @..WoWPro_Events.lua:203 CreateGuideTabFrame = <func> @..WoWPro_GuideList.lua:368 OnInitialize = <func> @..WoWPro.lua:238 UnregisterAllEvents = <func> @Ace3..CallbackHandler-1.0.lua:202 GuideTabFrame_RowOnClick = <func> @..WoWPro_GuideList.lua:270 NextGuideDialog = Guide Completed {} LoadNilGuide = <func> @..WoWPro_NilGuide.lua:5 stickycount = 0 actionlabels = <table> {} LogEvent = <func> @..WoWPro.lua:88 RowSet = <func> @..WoWPro_Frames.lua:318 optionalcount = 0 AutoCompleteLoot = <func> @..WoWPro_Events.lua:85 Questline = <func> @..WoWPro_Broker.lua:737 RecordTaxiLocations = <func> @..WoWPro_Events.lua:8 ShownRows = 1 mixins = <table> {} CreateStep = <func> @..WoWPro_Widgets.lua:34 GetName = <func> @Ace3..AceAddon-3.0.lua:300 FirstMapCall = true GenerateMapCache = <func> @..WoWPro_Zones.lua:2994 CreateGuideList = <func> @..WoWPro_GuideList.lua:8 name = “WoW—————————-~Mach
Re: WoW-Pro Alpha1Try going into the addon config window and “enable debugging” and then try selecting a guide and then “display the log” and copy/paste that into a comment here!
Re: Alliance Zangarmarsh bug OK. I think I know what the problem is. I’ll try to reproduce it and fix it tomorrow.Time for beer and sleep.
Re: Acid Test #2? – Klaxxi… Failed!Whoa! Interesting. This would indicates some problems specific to the guide itself.I would normally take a look at it right now, but I ran a half marathon around noon and just came back from getting a 90 minute deep tissue massage.I think once I have dinner and a beer, that I am just gonna crash! So I’ll peek tomorrow.
Re: A few thingsYou should turn off the “Recorder” addon. That one is only for guide writers and is currently not compatible with the other ones, because of the changes I made!
Acid Test #2? – Klaxxi… Failed!20130317/1609.001 ~ WoWPro: Patched Blizzard_GlyphUI to get rid of attempt to index global “PlayerTalentFrame” (a nil value)
20130317/1609.002 ~ WoWPro: PLAYER_ENTERING_WORLD()
20130317/1609.003 ~ WoWPro: QUEST_LOG_UPDATE()
20130317/1609.004 ~ WoWPro: UNIT_AURA(“player”)
20130317/1609.005 ~ WoWPro: UNIT_AURA(“player”)
20130317/1609.006 ~ WoWPro: QUEST_LOG_UPDATE()
20130317/1609.007 ~ WoWPro: Resetting Guide WayKlaxxi due to upgrade. Forgetting skipped steps.
20130317/1609.008 ~ WoWPro: In guide WayKlaxxi, quest 31175’s name [Skeer The Bloodseeker] does not match Grail’s database [Skeer the Bloodseeker].
20130317/1609.009 ~ WoWPro: In guide WayKlaxxi, quest 31175’s name [Skeer The Bloodseeker] does not match Grail’s database [Skeer the Bloodseeker].
20130317/1609.010 ~ WoWPro: In guide WayKlaxxi, quest 31018’s name [Beneath The Heart Of Fear] does not match Grail’s database [Beneath the Heart of Fear].
20130317/1609.011 ~ WoWPro: In guide WayKlaxxi, quest 31018’s name [Beneath The Heart Of Fear] does not match Grail’s database [Beneath the Heart of Fear].
20130317/1609.012 ~ WoWPro: Invalid Z tag in:R Kypari Zar|QID|31272;31268;31271;31269;31267;31024;31270|Z|Kypari Zar
|Get your favorite Klaxxi buff from any of the available Paragons then speak to Kil’ruk the Wind-Reaver for a lift to Kypari Zar. Press 1 and choose your landing spot.|CC|
20130317/1609.013 ~ WoWPro: Invalid Z tag in:R The Scale-Lord|QID|31269|Z|Mistblade Den
|Cave Entrance|CC|M|66.73,63.61|
20130317/1609.014 ~ WoWPro: Invalid Z tag in:R Terrace of Gurthan|QID|31233;31232;31231;31237;31235;31234|M|55.10,35.90|Z|Terrace of Gurthan
|Get your favorite Klaxxi buff from any of the available Paragons then speak to Kil’ruk the Wind-Reaver for a lift to The Terrace of Gurthan. Press 1 and choose your landing spot.|CC|
20130317/1609.015 ~ WoWPro: Invalid Z tag in:R Zan’Vess|QID|31111;31508;31509;31506;31505;31507;31510|Z|The Briny Muck
|Get your favorite Klaxxi buff from any of the available Paragons then speak to Kil’ruk the Wind-Reaver for a lift to Zan’Vess. Press 1 and choose your landing spot.|CC|
20130317/1609.016 ~ WoWPro: In guide WayKlaxxi, quest [Seeds of Fear] does not have a QID
20130317/1609.017 ~ WoWPro: QUEST_LOG_UPDATE()
20130317/1609.018 ~ WoWPro: ZONE_CHANGED_NEW_AREA()
20130317/1611.019 ~ WoWPro: CHAT_MSG_SYSTEM(“Pendelicious has gone offline.”, “”, “”, “”, “”, “”, 0, 0, “”, 0, 18, nil, 0, false, false)
20130317/1611.020 ~ WoWPro: QUEST_LOG_UPDATE()
20130317/1611.021 ~ WoWPro: QUEST_LOG_UPDATE()
A few thingsShould there be a recording bar at the top of the guide window?The zip file created a folder called WoW-Pro-Guides-master that contained the guide folders, had to copy them out of that into the addons folder.I’m also getting some lua errors but don’t have time to figure out if they are solely from the guide or another addon, hopefully will have some more time tonight to check it out and report back. That said, 2.5 has been working great, just came back after a long break and have been working through MoP content with it.keep up the good work
WoW-Pro Alpha1Hey, Thanks for the time with the addon, i downloaded the most recent version directly from github today, and made sure to delete every savedvariable before testing.When i select a guide from the guide list nothing comes up in the guide window tho, seems to me like it fails to properly load the guide steps.I have no current “error” reports though as i did not see any lua errors while testing.~Mach
Yay for Ludo*puts a skimpy cheerleader outfit on his Draenei Mage and lets her chant your name while dancing* Great work, those “accidental” bugfixes will really enhance the quality of the addon!D. Automatic flight point autocomplete works (fingers crossed) uniformly… What a shame. You got through all the hard work for this step just as Blizz changed the flight point behavior back to how it was pre-cataclysm: There are no more automatic flight points, so this step will probably only show up if someone travelled to a zone and got its fligh points before starting the guide for that zone 😛
Alliance Zangarmarsh bug On the step Fertile Spores it is showing I have 7/6 Fertile Spores, with a check in the box, but it does not go on to the next step when I log in. Also getting the following error in the chat log: WowPro: In guide JamZan6264, quest 29566’s name [Checking up] does not match Grail’s database [Checking Up].I’m assuming(!!!) it’s the case of the ‘U’ Mike
Version 2.6.0alpha1Version 2.6.0alpha1 is availible at:https://github.com/Jiyambi/WoW-Pro-Guides/archive/master.zipFind a bug. report it at this blog entry!
Acid Test #1I just did the Golden Lotus Dalies.The guide reset properly from yesterday, automaticallyI got no quest skipsThe end of guide step showed up rightI have a couple of patches for the guide to upload that will get rid of a little noise at the start, though.