Pandaria Lost and Found Achievement

Re: I thought error checking wasAt one point I fixed this by removing the “FLAG – ” from the official quest name and then matching it against the quest name in the guide.But it looks like a bunch of the quest names have been changed!I’ll fix this by not bothering to check if the quest starts with “FLAG -“.  

I thought error checking wasI thought error checking was turned off for the flag quests?Basically what its from is the guide uses the name of the item found, because sometimes Blizzard changed the name of the item after they made the quest so there is a mismatch and originally the quests were named “FLAG – whatever” — which was rather meaningless so I used the correct names.  Then when the error checking against qrail was added we got the above error messages :(I solved it by diabling grail except when I specifically want it.

New errors, fromNew errors, from today….20131107/1121.001 ~ WoWPro: Disabled: Core Addon20131107/1147.002 ~ WoWPro: Initializing Guide EmmAchLost.20131107/1147.003 ~ WoWPro: In guide EmmAchLost, quest 31284’s name [Ancient Pandaren Fishing Charm] does not match Grail’s database [Ancient Pandaren Fishing Pole].20131107/1147.004 ~ WoWPro: In guide EmmAchLost, quest 31864’s name [Chest of Supplies] does not match Grail’s database [Box of Supplies].20131107/1147.005 ~ WoWPro: In guide EmmAchLost, quest 31402’s name [Ancient Jinyu Staff] does not match Grail’s database [Waterspeaker’s Staff].20131107/1147.006 ~ WoWPro: In guide EmmAchLost, quest 31865’s name [Offering of Remembrance] does not match Grail’s database [Offering of Rememberance].20131107/1147.007 ~ WoWPro: In guide EmmAchLost, quest 31396’s name [Ship’s Locker] does not match Grail’s database [Ship’s Storage].20131107/1147.008 ~ WoWPro: In guide EmmAchLost, quest 31411’s name [Recipe: Banana Infused Rum] does not match Grail’s database [Banana Infused Rum].20131107/1147.009 ~ WoWPro: In guide EmmAchLost, quest 31666’s name [Wind-Reaver’s Dagger of Quick Strikes] does not match Grail’s database [Wind-Reaver’s Dagger].20131107/1147.010 ~ WoWPro: In guide EmmAchLost, quest 31434’s name [Swarming Cleaver of Ka’roz] does not match Grail’s database [Swarming Cleaver].20131107/1147.011 ~ WoWPro: In guide EmmAchLost, quest 31437’s name [Swarmkeeper’s Medallion] does not match Grail’s database [Swarmkeeper’s Crossbow].20131107/1147.012 ~ WoWPro: In guide EmmAchLost, quest 31435’s name [Dissector’s Staff of Mutation] does not match Grail’s database [Dissector’s Staff].20131107/1147.013 ~ WoWPro: In guide EmmAchLost, quest 31436’s name [Bloodsoaked Chitin Fragment] does not match Grail’s database [Bloodseeker’s Frenzied Mace].20131107/1147.014 ~ WoWPro: In guide EmmAchLost, quest 31438’s name [Blade of the Poisoned Mind] does not match Grail’s database [Hammer of the Poisoned Mind].20131107/1147.015 ~ WoWPro: In guide EmmAchLost, quest 31431’s name [Lucid Amulet of the Agile Mind] does not match Grail’s database [Lucid Amulet].20131107/1147.016 ~ WoWPro: Step A [Hozen Warrior Spear:31413] in EmmAchLost is missing a CS|CC|CN tag.20131107/1147.017 ~ WoWPro: In guide EmmAchLost, quest 31417’s name [Tablet of Ren Yun (Recipe)] does not match Grail’s database [Tablet of Ren Yun].20131107/1147.018 ~ WoWPro: In guide EmmAchLost, quest 31421’s name [Sturdy Yaungol Spear] does not match Grail’s database [Stash of Yaungol Weapons].20131107/1147.019 ~ WoWPro: In guide EmmAchLost, quest 31284’s name [Ancient Pandaren Fishing Charm] does not match Grail’s database [Ancient Pandaren Fishing Pole].20131107/1147.020 ~ WoWPro: In guide EmmAchLost, quest 31864’s name [Chest of Supplies] does not match Grail’s database [Box of Supplies].20131107/1147.021 ~ WoWPro: In guide EmmAchLost, quest 31402’s name [Ancient Jinyu Staff] does not match Grail’s database [Waterspeaker’s Staff].20131107/1147.022 ~ WoWPro: In guide EmmAchLost, quest 31865’s name [Offering of Remembrance] does not match Grail’s database [Offering of Rememberance].20131107/1147.023 ~ WoWPro: In guide EmmAchLost, quest 31396’s name [Ship’s Locker] does not match Grail’s database [Ship’s Storage].20131107/1147.024 ~ WoWPro: In guide EmmAchLost, quest 31411’s name [Recipe: Banana Infused Rum] does not match Grail’s database [Banana Infused Rum].20131107/1147.025 ~ WoWPro: In guide EmmAchLost, quest 31666’s name [Wind-Reaver’s Dagger of Quick Strikes] does not match Grail’s database [Wind-Reaver’s Dagger].20131107/1147.026 ~ WoWPro: In guide EmmAchLost, quest 31434’s name [Swarming Cleaver of Ka’roz] does not match Grail’s database [Swarming Cleaver].20131107/1147.027 ~ WoWPro: In guide EmmAchLost, quest 31437’s name [Swarmkeeper’s Medallion] does not match Grail’s database [Swarmkeeper’s Crossbow].20131107/1147.028 ~ WoWPro: In guide EmmAchLost, quest 31435’s name [Dissector’s Staff of Mutation] does not match Grail’s database [Dissector’s Staff].20131107/1147.029 ~ WoWPro: In guide EmmAchLost, quest 31436’s name [Bloodsoaked Chitin Fragment] does not match Grail’s database [Bloodseeker’s Frenzied Mace].20131107/1147.030 ~ WoWPro: In guide EmmAchLost, quest 31438’s name [Blade of the Poisoned Mind] does not match Grail’s database [Hammer of the Poisoned Mind].20131107/1147.031 ~ WoWPro: In guide EmmAchLost, quest 31431’s name [Lucid Amulet of the Agile Mind] does not match Grail’s database [Lucid Amulet].20131107/1147.032 ~ WoWPro: Step A [Hozen Warrior Spear:31413] in EmmAchLost is missing a CS|CC|CN tag.20131107/1147.033 ~ WoWPro: In guide EmmAchLost, quest 31417’s name [Tablet of Ren Yun (Recipe)] does not match Grail’s database [Tablet of Ren Yun].20131107/1147.034 ~ WoWPro: In guide EmmAchLost, quest 31421’s name [Sturdy Yaungol Spear] does not match Grail’s database [Stash of Yaungol Weapons].I’d edit, but I dont know exactly what I’d be doing 😉  

For sure! I may even haveFor sure! I may even have some demos that you fine folks can try out. Indie style, very low budget, kind of stuff – but hopefully still fun. But atm I’m doing sort of bite-size projects where I’m learning a specific part of game programming, such as 3d graphics or AI.

Game Programmer? Sounds fun!Welcome back Jiyambi! Let us know when your career choice has led to a finished game and I will probably buy it xD

Achievement CategoryI noticed this and TwoToad’s Squirrels guide are listed as category “Achievement”. I would suggest we place this one in “Exploration” since that’s it’s in-game category, and Squirrels as “General” for the same reason. However, this might make it harder to find, so I’m not sure.

I saw the RANK tags, theyI saw the RANK tags, they look right to me – but I honestly haven’t looked at addon code in over a year! Anyway, it’s a very clever solution but seems more fitting for people who are looking to do Lost and Found but also want to do Riches of Pandaria. The converse doesn’t work as well since the rank tags only go one way.Mostly I ask because I already wrote the guide (it’s very short) before I checked here – I had an outdated version of the addon that didn’t include your excellent guide 😀 So, I may post mine up and y’all can include it if you like, and I think a note referencing your guide would be an excellent idea. Lost and Found can take quite a lot of time to complete, but someone can bang out Riches of Pandaria in maybe around 15 minutes.I might delve into the code again sometime and check that RANK tag issue. However, no promises as I have coursework submission for the next two weeks (read: lots of projects). Following that I may be less busy as the new term will be starting, but I have to work on side game projects as well (I’m working on a game programming degree). Anyways, we’ll see 🙂

re: useful?Hey Jiyambi, welcome back :)The riches of pandaria ach was added in 5.1 (so the name of the existing guide doesnt reflect it – i will change it. ) I think as long as you are working on the lost and found chain you may as well get riches of pandaria in the process.  I have been tempted to combine it with the Lorewalkers guide too, since it also has you flying all over the world.But… that being said, having a seperate one for just riches of pandaria  doesn’t hurt.  I would recomend a note at the top of it that says if you also want to look for the rare items use the Lost and Found guide instead.  If you like challenges, you could get the RANK tag to work right for Lost and Found guide.  I think I did it right (in the guide) and it is something wrong in the parser… but maybe its just the formatting of the guide /shrug.

Useful to separate?Hey Em,I started working on a “Riches of Pandaria” guide before I saw you had this here beauty. I was wondering if you think it would be helpful to have a separate guide that just has the Riches of Pandaria stuff in it, in addition to this one. Let me know what you think 🙂

RE: tested – YAY!The jumping back behaviour is normal, and some guides, like the Nether Drake one, depend on it.For good or ill, the way the engine works is that it all steps not marked as complete or skipped are eligible to be the “next” step when the current step is done.The change in rep should be picked up, but only at the time the next step is computed.  There is a race condition such that the client may not report the change in rep before we have picked the next step.I’ll see if there is a different event we can pick up for that.  I think the World Events module had some special logic for rep and acheivement changes that might be more general. 

tested – YAY!I ran thru the guide and of course now that the logic is working found a couple of mistakes I had made, and some things that I think will improve it.  I made the changes to my personal copy and will test them tomorrow and add them  here if they work out :)I noticed something that I dont know if it is fixable…If you get the rep needed for a quest from turning in the previous quest, the guide doesn’t seem to know it, so doesnt tell you the next quest is available.  I think that is covered with my statement at the beginning of the guide to take every quest you see, (except the turn in dark soil items).Also, if you pick up a quest out of order (not when the guide tells you to.  in this example it was A wolf in sheeps clothing – line 180 in my copy of the code) I was actually in the guide right after turning in oh sheepie (line 255)  the guide jumps backwards to the place where the C step for that quest is (line 192).  It was my idea that the guide would tell you to do that step the next time you run thru (i.e. tomorrow).  This is not new behavior, but I don’t think I’ve commented on it before, since the whole guide in general wasnt working right. Is that normal? should it be normal?

Re: Re: sorry to introduce yet another complication to that mix.OK.   Fix implemented and checked in with 15 minutes to go before my first conference call.It still has a debug print statement in there that will need to be removed for a new cut.It correctly identified Gina as an Acquaintance and computed the right earned rep.

Re: sorry to introduce yet another complication to that mix… OK. So notes for myself after breakfast (never program before breakfast and coffee):
[code]
/dump GetFriendshipReputation(1283)
[/code]
returns:
[code]
[1]=1283 ; — the rep ID
[2]=5720 ; — the current rep level (current level or absolute? we shall try Gina and see)
[3]=42999; — the max rep level
[4]=”Farmer Fung” ; — NPC name
[5]=”Farmer Fung considers you a stranger. Farmer Fung likes Marsh Lilies and Wildfowl Roast”; — NPC Text
[6]= ; — Some strange return
[7]=”Stranger” ; — Text standing ID
[8]=0 ; — friend threshold
[9]=8400 ; — how many points to the next level
[/code]
The next example:
[code]
/dump GetFriendshipReputation(1281)
[/code]
returns:
[code]
[1]=1281;
[2]=14300;
[3]=42999;
[4]=”Gina Mudclaw”;
[5]=”Gina Mudclaw considers you an Acquantance …”;
[6]=;
[7]=”Acquaintance”;
[8]=8400;
[9]=16800;
[/code]
Since 14300 – 8400 = 5900, which is my standing in Acquaintance, [2] is an absolute level.

I will need to convert the text in [7] to a number.. Time for a table. Then I can use the table for both the if statements and the lookup.

Lucky I am still home from my eye operation :-).

sorry to introduce yet another complication to that mix… but..In your newest iteration of the GetFriendshipReputation… — from wowpro_broker.lua lines 310-312
local friendID, friendRep, friendMaxRep, friendName, friendText, friendTexture, friendTextLevel, friendThreshold, nextFriendThreshold

if Friendship then

friendID, standingId, friendMaxRep, name, friendText, friendTexture, friendTextLevel, friendThreshold, nextFriendThreshold = GetFriendshipReputation(factionIndex);

you have assigned the variable defined in the function as friendrep to standingID. This is not what that variable is. That variable is the numeric value of the rep (on the full scale 0-42000), you could do math on that value to come up with standing id (ie. integer value of friendrep/8400)? or you could do string matching on the value friendTextLevel which will return the values {stranger…best friend} … but, the way you have it now won’t work.

I know and accept that you have a full scheudle like most people and this is a hobby. I am indead impatient, which is why I keep mucking around in it, trying to find how to do it myself. None of my ideas how to implement it have worked well. I had it working for best friend, but not for any of the lower lvls… I suspect because it was bypassing the whole calculation i was trying to do and instead going to the statement of else repmax=8

Now Ive gone to rambling, I better quit typing too… I hope you can find time for this 🙂

Re: ah, ok. those were mostly for … and ThanksI have to say that I have enjoyed our collaboration very much.   It’s nice to have someone who keeps me on my toes and is willing to ask questions, especially the “Why can’t this work better” kind.   I’m just sorry I don’t have more bandwith to keep up on things.  Between Blizzard mucking with things (I had tested things on the PTR, but they changed things between that build and the official one), new content on each release and things at home (Meperitab makes it very hard to think), and one functional eye it has been a challenge.I really have to level up my Horde toon up; my poor Belf Blood DK would really help testing out these new guides. All those new scenarios, new raids, and pet battles.   When I joined my first guild on Wow, one of the big concerns was what to do after you reached 80 and did “everything”.  Now it seems almost impossible to finish “everything”.So, thanks again!   You have  help make the game more enjoyable for me on a personal level.  Never mind those 10-20 thousand people who dowload our addon!OK, time to stop this drug induced babble …. and back to cutting a patch.   

ah, ok. those were mostly forah, ok. those were mostly for my own internal version control anyway :)… I tried to duplicate the same thing in the change log section of the wiki.  (like usually cut and paste) I won’t put it in the top on the wiki anymore.  (but it will be there if I post it to github — with the forementioned statement that what I put on github most likely isn’t distribution ready.And thanks. If I ever have any more new guides, I have a way to post them that won’t require you to then move them.  I may at some point do one for the krasarang wilds horde side, but someone else may get to it first as my first priority right now is getting shadopan/august celestials rep done (not the guide… actually doing the dailies) and finishing my hunters last about 4 bubbles of 89 so I can start all over with the dailies… /sigh

Re: HUH?I mean the comments you have  at the top, like:— Date 1 Dec 2012
— Who: Emmaleah
— Log: 5.1 added a new achievement. adding mention of it to the guideWe the webscraping program looks for the text between:WoWPro.Achievements:RegisterGuide(…]]
end)and downloads that.  The comments up on top will not be copied into GitHub.PS:  I tweaked a setting.  You should have permissions to create and delete your own wiki pages now.  Bad system setting.

HUH?This left me confused.  If i interpreted correctly… for some reason the version here… (which I think is the correct one) has a differant Guide ID than the one on github.  (I can see why that would cause it not to update.)  The one on github appears to be an iteration before I was done with it, hence the oddities in the registration,  (I was trying to see if registering it as a leveling guide would allow it to work. — and obviously got sidetracked and didn’t fix it back to dailies correctly.) That part I followed. (I think)… but… what do you mean about comments?  Did I put some comments somewhere else that should have made it to the final release and you are telling me that I put them the wrong place?  I think everything I expect to “go live” I put here (in the body of the wiki for that particular guide).  The only stuff I post on github nowadays, is stuff I want you to look at and either fix or advise me on.  The only other exception would be new guides which I put on my blog since I can’t create wikis.

Re: Pandaria Lost and Found Achievement not updatingThe guide in GitHub had a different guide ID.  Unless the two match, the updater can not match the up.BTW, comments you add will not get into the source code.   Only official revision comments in a wiki page will be added to the source.