Pandaria Lost and Found Achievement

This article needs more details/information/content.
You are currently viewing a Wiki Page. It can be edited by anyone who is currently logged in. Before you change anything, please make sure to read our FAQ, the editing guidelines of this post as well as its comments.



Pandaria Lost and Found/Riches of Pandaria Achievement Source Code


-- Date 1 Dec 2012
-- Who: Emmaleah
-- Log: 5.1 added a new achievement. adding mention of it to the guide

-- Date: 8 Nov 2012
-- Who: Emmaleah
-- Log: fixed coords for niuzio catacombs (was using from wrong map)

-- Date: 3 Nov 2012
-- Who: Emmaleah
-- Log: After many iterations, I think the steps are in a relatively efficient order. (still haven't solved the other items on the to do list. posting it so hopefully someone else can.)

-- Date: 20 Oct 2012
-- Who: Emmaleah
-- Log: Initial Guide, info taken from Wowhead, and my personal observations.

-- To Do:
-- Changing ranks doesn't seem to do anything but I can't seem to figure out why

local guide = WoWPro:RegisterGuide('EmmAchLost',"Achievements",'MoP Zones', 'Lost and Found - Riches of Pandaria','Neutral')
-- WoWPro:GuideIcon(guide,"ACH",XXX)
WoWPro:GuideNextGuide(guide, 'Emmaleah')
WoWPro:GuideSteps(guide, function()
return [[

N Lost and Found|QID|972810001|N|This guide is for all of the lost things in Pandaria, not just the ones that give this achievement. There are actually four achievements in the chain for finding 1, 5, 10 and finally 20 items. There are a total of 28 that can be found that qualify. Most of the items for the achievement are BOA and all are blue quality, except the two recipes(white) and the ancient woodcutter(grey). These items are rare, thus not always there.|
N Riches of Pandaria|QID|979940001|N|Patch 5.1 brought new achievements. This is a chain of achievements for finding the grey items, each worth ~100g. The achievements are called Treasures of Pandaria - finding 1; Fortune of Pandaria - finding 5; Bounty of Pandaria - finding 10; and lastly, Riches of Pandaria - finding all 18. These items are common and will always be available. Some of them move around in the general location. others are a static spawn.|
N Setting of Ranks|QID|972810001|N|If you are only interested in the Lost and Found achievement set the guide to RANK 1. RANK 2 includes the items for Riches of Pandaria achievement as well. These items mostly sell for 100+gold. The items that give little gold or xp, nor are part of any achievement should only be included if you set it to RANK 3.|
N Basic "how it works"|QID|972810001|N|These use hidden "flag" quests so that the items will only be available once per character. If you move while opening the container (including being attacked) you may lose the item, and so far GMs have not been replacing, Also, if your inventory is full, no item. You do get the achievement even if you don't get the item. If you are using this addon, you do not need the scripts on Wowhead to tell you which ones you haven't yet found, as that is what this does, by checking off the steps as you find them.|
N Some require NPC Interaction|QID|972810001|N|Some of the items require you talk to NPC's to get the item (instead of groundspawns). There are target buttons for those steps, the number beside their name (in the note) is their NPC code if you want to add to NPC Scan.|
N Some may already be completed|QID|972810001|N|These all give XP If done pre-90 so the leveling guides have you look for several (most) of them. The ones for the achievement are rare, you will need to manually skip several of them (since they won't be there) and come back another day. Reset the guide to unmark the skipped steps and start over.|
N One Last Note|QID|972810001|N|Despite these showing a yellow "!" in the guide steps, you do not actually accept a quest or see a "!" over the item on the ground.|

A Ancient Pandaren Fishing Charm|QID|31284|L|85973|RANK|1|T|Ghostly Pandaren Fisherman|M|46.8,24.6|Z|Valley of the Four Winds|N|Talk to 'Ghostly Pandaren Fisherman'[64004](possibly beside any lake}.|
A Ancient Pandaren Woodcutter|QID|31292|L|86079|RANK|1|T|Ghostly Pandaren Craftsman|M|45.4,38.2|Z|Valley of the Four Winds|N|Talk to 'Ghostly Pandaren Craftsman'[64191]He wanders thru Halfhill and into the Heartland.|
A Cache of Pilfered Goods|QID|31406|RANK|1|M|43.54,35.16|Z|Valley of the Four Winds|N|Virmin cave on Mudclaw Farm. Loot (ilvl 419 BoP neck) will be specific to your current spec.|

A Forgotten Lockbox|QID|31867|RANK|3|M|54.71,71.41|Z|The Veiled Stair|N|2nd Floor of the Inn.|
A Hammer of Folly|QID|31428|L|86473|RANK|2|M|74.98,76.56|Z|The Veiled Stair|N|Top of Mason's Folly.|

A Chest of Supplies|QID|31864|RANK|2|M|24.65,53.29|Z|The Jade Forest|N|Between Jade Forest/Valley of the 4 winds, by overturned boat, below the Veiled Stair/Ancient Passage Waterfall.|
A Pandaren Ritual Stone|QID|31404|L|86216|RANK|2|M|23,35|Z|The Jade Forest|N|Island in Lake Kittitata NW Camp Nooka Nooka.|
A Ancient Pandaren Tea Pot|QID|31400|L|85780|RANK|2|M|26.2,32.3|Z|The Jade Forest|N|On table, Shrine of the Moon.|
A Lucky Pandaren Coin|QID|31401|L|85781|RANK|2|M|31.96,27.76|Z|The Jade Forest|N|In fountain, Shrine of the Sun.|
A Wodin's Mantid Shanker|QID|31397|L|85776|RANK|1|M|39.4,7.3|Z|The Jade Forest|N|Owen's Wishing Well. Terrace of Ten Thunders.|
A Hammer of Ten Thunders|QID|31403|L|86198|RANK|1|M|43,11.6;41.8,17.6|Z|The Jade Forest|CN|N|Seat of the Spirit Walker, Terrace of Ten Thunders.|
A Stash of Gems|QID|31866|L|RANK|3|M|62.47,27.55|Z|The Jade Forest|N|Cave in Windward Isle - Shadowfae Madcap, spawn point, I wouldn't recommend this one pre lvl 90.|
A Ancient Pandaren Mining Pick|QID|31399|L|85777|RANK|1|M|46.1,29.1;44.1,27.0;43.8,30.7|Z|The Jade Forest|CN|N|Multiple spots in Greenstone Mine.|
A Jade Infused Blade|QID|31307|L|86199|RANK|1|T|Jade Warrior Statue|M|39.4,46.65|Z|The Jade Forest|N|Talk to 'Jade Warrior Statue'[64272] at Jade Witch's house.|
A Ancient Jinyu Staff|QID|31402|L|86196|RANK|1|M|47.1,67.4;46.2,71.2;44.9,64.6|Z|The Jade Forest|CN|N|Many spots, bottom of river near Grookin Hill.|
A Offering of Remembrance|QID|31865|RANK|3|M|46.3,80.7|Z|The Jade Forest|N|Money bag - on the alter. Debuff is visual effect only.|
A Ship's Locker|QID|31396|RANK|2|M|70.13,74.5|Z|Pandaria|N|Lower deck, possibly any sunken ship.|

A Boat-Building Instructions|QID|31869|L|87524|RANK|3|M|79.79,4.45;88.53,50.6|CC|Z|Valley of the Four Winds|N|in Hut along shore, just down from finding Yi mo (Krasarang).|
A Saurok Stone Tablet|QID|31408|L|86220|RANK|2|M|75,55|Z|Valley of the Four Winds|N|2nd room of Saurok cave.|
A Pandaren Fishing Spear|QID|31409|L|86124|RANK|1|M|50.8,49.4|Z|Krasarang Wilds|N|Almost underneath Uncle Deming.|
A Stack of Papers|QID|31863|L|87798|RANK|3|M|52.2,73.4|Z|Krasarang Wilds|N|Path up hill is back side of Marista Island, papers are next to gnome skeletons and hatch.|
A Recipe: Banana Infused Rum|QID|31411|L|87266|RANK|1|M|52.36,88.64|Z|Krasarang Wilds|N|Top of hill, barrel on deck of boat/platform coming out of hill.|
A Equipment Locker|QID|31410|RANK|1|M|42.3,92|Z|Krasarang Wilds|N|Pirate ship (non-sunken) west of Unga Ingoo, in the lowest level of the ship. Loot (ilvl 419 BoP boots) will be specific to your current spec.|

A Virmen Treasure Cache|QID|31405|RANK|2|M|23.71,28.29|Z|Valley of the Four Winds|N|Must be able to fly. Hidden (from the ground) virmen in cave cliffs NE Paoquan Hollow, directly below Mistfall Village.|
A Staff of the Hidden Master|QID|31407|L|86218|RANK|1|M|19.1,37.9;15.0, 33.7;19.0,42.5|Z|Valley of the Four Winds|CN|N|Paoquan Hollow leaning against bamboo shoots, multiple locations, so look around.|

A Wind-Reaver's Dagger of Quick Strikes|QID|31666|L|86519|RANK|1|M|71.8,36.1|Z|Dread Wastes|N|Near base of a pillar.|;31429 may be the QID, listed as both on Wowhead.
A Blade of the Prime|QID|31433|L|86522|RANK|1|M|66.8,63.8|Z|Dread Wastes|N|Stuck in wall, Mistblade Den (lake of the stars).|
A Swarming Cleaver of Ka'roz|QID|31434|L|86523|RANK|1|M|56.8,77.6|Z|Dread Wastes|N|Underwater, near Soggy's Gamble.|
A Swarmkeeper's Medallion|QID|31437|L|86526|RANK|1|M|54.2,56.4|Z|Dread Wastes|N|Slightly north of Kyparizar.|
A Manipulator's Talisman|QID|31432|L|86529|RANK|1|T|Glinting Rapana Whelk|M|42,62.2|Z|Dread Wastes|N|Briny Muck - Talk to 'Glinting Rapana Whelk'[65552].|
A Dissector's Staff of Mutation|QID|31435|L|86524|RANK|1|M|30.2,90.8|Z|Dread Wastes|N|Amber Quarry/Zan'vess Island.|
A Bloodsoaked Chitin Fragment|QID|31436|L|86525|RANK|1|M|25.5,54.25;25.9,50.3|Z|Dread Wastes|CS|N|Inside Murkscale Grotto,(underwater cave). First coord is entrance.|
A Blade of the Poisoned Mind|QID|31438|L|86527|RANK|1|M|28.88,41.99|Z|Dread Wastes|N|Outside a cave, hidden inside the smaller of two bushes.|
A Malik's Stalwart Spear|QID|31430|L|86520|RANK|1|M|48.7,30|Z|Dread Wastes|N|Clutches of Shek'zerr.|
A Lucid Amulet of the Agile Mind|QID|31431|L|86521|RANK|1|M|33,30.07|Z|Dread Wastes|N|Heart of Fear.|

A Amber Encased Moth|QID|31426|L|86472|RANK|2|M|65.82,86.06|Z|Townlong Steppes|N|Ambermarsh.|
A Fragment of Dread|QID|31423|L|86516|RANK|2|M|32,61|Z|Townlong Steppes|N|Coordinates are to entrance, it can spawn many places in Niuzao Catacombs (and will move each time it's looted).|
A Hardened Sap of Kri'vess|QID|31424|L|86517|RANK|2|M|57.4,56.6|Z|Townlong Steppes|N|Among roots of giant tree at Kiri'vess - many coords reported. So look all around the tree.|
A Yaungol Fire Carrier|QID|31425|L|86518|RANK|1|M|66.3,44.7;66.8,48|Z|Townlong Steppes|CN|N|Fire Camp Osul - on a brazier.|
A Abandoned Crate of Goods|QID|31427|RANK|2|M|62.76,34.08|Z|Townlong Steppes|N|Inside burning tent just west of Serpent's Spine wall.|

A Kafa Press|QID|31304|L|86125|RANK|1|M|37.5,78.0;35.2,76.3|Z|Kun-Lai Summit|CS|N|Inside an ice block 'Frozen Trail Packer'[64227]southernmost yeti cave(first coords cave entrance).|
A Lost Adventurer's Belongings|QID|31418|RANK|2|M|36.7,79.8|Z|Kun-Lai Summit|N|Kota Peak (at Ski'thik spawn point).|
A Terracotta Head|QID|31422|L|86427|RANK|2|M|59.25,73|Z|Kun-Lai Summit|N|Mogujia - appears just like all the other Terracotta statue pieces.|
A Hozen Treasure Cache|QID|31414|RANK|2|M|49.5,59.4|Z|Kun-Lai Summit|N|Knucklethump hole, at back of the big cave.|
A Hozen Warrior Spear|QID|31413|L|86394|RANK|1|M|52.9,71.1;51.5,74|Z|Kun-Lai Summit|CS|N|Middle of underground pool in cave "The Deeper" (room adjacent Dak Dak's alter) BoA Agi Polearm.|
A Mo-Mo's Treasure Chest|QID|31868|RANK|3|M|47,73|Z|Kun-Lai Summit|N|In Mo Mo's cave.|
A Tablet of Ren Yun (Recipe)|QID|31417|L|86393|RANK|1|M|44.7,52.4|Z|Kun-Lai Summit|N|Beside Ren Yun's statue (Panda Shrine} - top of Mt Neverest.|
A Rikktik's Tick Remover|QID|31419|L|86430|RANK|2|M|52,51|Z|Kun-Lai Summit|N|Rikktik's tomb - Valley of the Emperors.|
A Ancient Mogu Tablet|QID|31420|L|86471|RANK|2|M|64,45|Z|Kun-Lai Summit|N|Path of the conquerers (on way to zouchin village behind statue - left side of room.|
A Statue of Xuen|QID|31416|L|86422|RANK|2|M|71,33|Z|Kun-Lai Summit|N|Zandalari area,SW of Zouchin Village, middle of pond.|
A Sturdy Yaungol Spear|QID|31421|L|88723|RANK|1|M|71.2,62.6;70.06,63.88|Z|Kun-Lai Summit|CN|N|located on weapons rack, Fire Camp Yongqi (any fire camp?) BoA Str polearm.|
A Stolen Sprite Treasure|QID|31415|RANK|2|M|56.8,48.9|Z|Kun-Lai Summit|N|End of Howlingwind Cavern.|
A Sprite's Cloth Chest|QID|31412|RANK|1|M|74.7,74.9|Z|Kun-Lai Summit|N|End of sprite cave. Loot (ilvl 434 cloak) will be specific to your current spec (and BOP).|

N Keep resetting|QID|972810001|N|until you find them all (or give up). In the end you should have earned the following eight achievements: Treasures of Pandaria; Fortune of Pandaria; Bounty of Pandaria: Riches of Pandaria; Lost and Found, Finders Keepers, One Man's Trash..., Is Another Man's Treasure.

]]
end)

Comments

New errors, from

New errors, from today....

20131107/1121.001 ~ WoWPro: Disabled: Core Addon20131107/1147.002 ~ WoWPro: Initializing Guide EmmAchLost.20131107/1147.003 ~ WoWPro: In guide EmmAchLost, quest 31284's name [Ancient Pandaren Fishing Charm] does not match Grail's database [Ancient Pandaren Fishing Pole].20131107/1147.004 ~ WoWPro: In guide EmmAchLost, quest 31864's name [Chest of Supplies] does not match Grail's database [Box of Supplies].20131107/1147.005 ~ WoWPro: In guide EmmAchLost, quest 31402's name [Ancient Jinyu Staff] does not match Grail's database [Waterspeaker's Staff].20131107/1147.006 ~ WoWPro: In guide EmmAchLost, quest 31865's name [Offering of Remembrance] does not match Grail's database [Offering of Rememberance].20131107/1147.007 ~ WoWPro: In guide EmmAchLost, quest 31396's name [Ship's Locker] does not match Grail's database [Ship's Storage].20131107/1147.008 ~ WoWPro: In guide EmmAchLost, quest 31411's name [Recipe: Banana Infused Rum] does not match Grail's database [Banana Infused Rum].20131107/1147.009 ~ WoWPro: In guide EmmAchLost, quest 31666's name [Wind-Reaver's Dagger of Quick Strikes] does not match Grail's database [Wind-Reaver's Dagger].20131107/1147.010 ~ WoWPro: In guide EmmAchLost, quest 31434's name [Swarming Cleaver of Ka'roz] does not match Grail's database [Swarming Cleaver].20131107/1147.011 ~ WoWPro: In guide EmmAchLost, quest 31437's name [Swarmkeeper's Medallion] does not match Grail's database [Swarmkeeper's Crossbow].20131107/1147.012 ~ WoWPro: In guide EmmAchLost, quest 31435's name [Dissector's Staff of Mutation] does not match Grail's database [Dissector's Staff].20131107/1147.013 ~ WoWPro: In guide EmmAchLost, quest 31436's name [Bloodsoaked Chitin Fragment] does not match Grail's database [Bloodseeker's Frenzied Mace].20131107/1147.014 ~ WoWPro: In guide EmmAchLost, quest 31438's name [Blade of the Poisoned Mind] does not match Grail's database [Hammer of the Poisoned Mind].20131107/1147.015 ~ WoWPro: In guide EmmAchLost, quest 31431's name [Lucid Amulet of the Agile Mind] does not match Grail's database [Lucid Amulet].20131107/1147.016 ~ WoWPro: Step A [Hozen Warrior Spear:31413] in EmmAchLost is missing a CS|CC|CN tag.20131107/1147.017 ~ WoWPro: In guide EmmAchLost, quest 31417's name [Tablet of Ren Yun (Recipe)] does not match Grail's database [Tablet of Ren Yun].20131107/1147.018 ~ WoWPro: In guide EmmAchLost, quest 31421's name [Sturdy Yaungol Spear] does not match Grail's database [Stash of Yaungol Weapons].20131107/1147.019 ~ WoWPro: In guide EmmAchLost, quest 31284's name [Ancient Pandaren Fishing Charm] does not match Grail's database [Ancient Pandaren Fishing Pole].20131107/1147.020 ~ WoWPro: In guide EmmAchLost, quest 31864's name [Chest of Supplies] does not match Grail's database [Box of Supplies].20131107/1147.021 ~ WoWPro: In guide EmmAchLost, quest 31402's name [Ancient Jinyu Staff] does not match Grail's database [Waterspeaker's Staff].20131107/1147.022 ~ WoWPro: In guide EmmAchLost, quest 31865's name [Offering of Remembrance] does not match Grail's database [Offering of Rememberance].20131107/1147.023 ~ WoWPro: In guide EmmAchLost, quest 31396's name [Ship's Locker] does not match Grail's database [Ship's Storage].20131107/1147.024 ~ WoWPro: In guide EmmAchLost, quest 31411's name [Recipe: Banana Infused Rum] does not match Grail's database [Banana Infused Rum].20131107/1147.025 ~ WoWPro: In guide EmmAchLost, quest 31666's name [Wind-Reaver's Dagger of Quick Strikes] does not match Grail's database [Wind-Reaver's Dagger].20131107/1147.026 ~ WoWPro: In guide EmmAchLost, quest 31434's name [Swarming Cleaver of Ka'roz] does not match Grail's database [Swarming Cleaver].20131107/1147.027 ~ WoWPro: In guide EmmAchLost, quest 31437's name [Swarmkeeper's Medallion] does not match Grail's database [Swarmkeeper's Crossbow].20131107/1147.028 ~ WoWPro: In guide EmmAchLost, quest 31435's name [Dissector's Staff of Mutation] does not match Grail's database [Dissector's Staff].20131107/1147.029 ~ WoWPro: In guide EmmAchLost, quest 31436's name [Bloodsoaked Chitin Fragment] does not match Grail's database [Bloodseeker's Frenzied Mace].20131107/1147.030 ~ WoWPro: In guide EmmAchLost, quest 31438's name [Blade of the Poisoned Mind] does not match Grail's database [Hammer of the Poisoned Mind].20131107/1147.031 ~ WoWPro: In guide EmmAchLost, quest 31431's name [Lucid Amulet of the Agile Mind] does not match Grail's database [Lucid Amulet].20131107/1147.032 ~ WoWPro: Step A [Hozen Warrior Spear:31413] in EmmAchLost is missing a CS|CC|CN tag.20131107/1147.033 ~ WoWPro: In guide EmmAchLost, quest 31417's name [Tablet of Ren Yun (Recipe)] does not match Grail's database [Tablet of Ren Yun].20131107/1147.034 ~ WoWPro: In guide EmmAchLost, quest 31421's name [Sturdy Yaungol Spear] does not match Grail's database [Stash of Yaungol Weapons].

I'd edit, but I dont know exactly what I'd be doing ;)

 

 

Ludovicus's picture

Re: I thought error checking was

At one point I fixed this by removing the "FLAG - " from the official quest name and then matching it against the quest name in the guide.

But it looks like a bunch of the quest names have been changed!

I'll fix this by not bothering to check if the quest starts with "FLAG -".

 

 

Emmaleah's picture

I thought error checking was

I thought error checking was turned off for the flag quests?

Basically what its from is the guide uses the name of the item found, because sometimes Blizzard changed the name of the item after they made the quest so there is a mismatch and originally the quests were named "FLAG - whatever" -- which was rather meaningless so I used the correct names.  Then when the error checking against qrail was added we got the above error messages :(

I solved it by diabling grail except when I specifically want it.

Jiyambi's picture

Achievement Category

I noticed this and TwoToad's Squirrels guide are listed as category "Achievement". I would suggest we place this one in "Exploration" since that's it's in-game category, and Squirrels as "General" for the same reason. However, this might make it harder to find, so I'm not sure.

Jiyambi's picture

Useful to separate?

Hey Em,

I started working on a "Riches of Pandaria" guide before I saw you had this here beauty. I was wondering if you think it would be helpful to have a separate guide that just has the Riches of Pandaria stuff in it, in addition to this one. Let me know what you think :)

Emmaleah's picture

re: useful?

Hey Jiyambi, welcome back :)

The riches of pandaria ach was added in 5.1 (so the name of the existing guide doesnt reflect it - i will change it. ) I think as long as you are working on the lost and found chain you may as well get riches of pandaria in the process.  I have been tempted to combine it with the Lorewalkers guide too, since it also has you flying all over the world.

But... that being said, having a seperate one for just riches of pandaria  doesn't hurt.  I would recomend a note at the top of it that says if you also want to look for the rare items use the Lost and Found guide instead. 

If you like challenges, you could get the RANK tag to work right for Lost and Found guide.  I think I did it right (in the guide) and it is something wrong in the parser... but maybe its just the formatting of the guide /shrug.

Jiyambi's picture

I saw the RANK tags, they

I saw the RANK tags, they look right to me - but I honestly haven't looked at addon code in over a year! Anyway, it's a very clever solution but seems more fitting for people who are looking to do Lost and Found but also want to do Riches of Pandaria. The converse doesn't work as well since the rank tags only go one way.

Mostly I ask because I already wrote the guide (it's very short) before I checked here - I had an outdated version of the addon that didn't include your excellent guide :D So, I may post mine up and y'all can include it if you like, and I think a note referencing your guide would be an excellent idea. Lost and Found can take quite a lot of time to complete, but someone can bang out Riches of Pandaria in maybe around 15 minutes.

I might delve into the code again sometime and check that RANK tag issue. However, no promises as I have coursework submission for the next two weeks (read: lots of projects). Following that I may be less busy as the new term will be starting, but I have to work on side game projects as well (I'm working on a game programming degree). Anyways, we'll see :)

Estelyen's picture

Game Programmer? Sounds fun!

Welcome back Jiyambi! Let us know when your career choice has led to a finished game and I will probably buy it xD

Life isn't like a box of chocolates, it's more like a jar of jalapeños: What you do today might burn your a** tomorrow.

~Garfield

Jiyambi's picture

For sure! I may even have

For sure! I may even have some demos that you fine folks can try out. Indie style, very low budget, kind of stuff - but hopefully still fun. But atm I'm doing sort of bite-size projects where I'm learning a specific part of game programming, such as 3d graphics or AI.

Ludovicus's picture

Re: Pandaria Lost and Found Achievement not updating

The guide in GitHub had a different guide ID.  Unless the two match, the updater can not match the up.

BTW, comments you add will not get into the source code.   Only official revision comments in a wiki page will be added to the source.

 

Emmaleah's picture

HUH?

This left me confused.  If i interpreted correctly... for some reason the version here... (which I think is the correct one) has a differant Guide ID than the one on github.  (I can see why that would cause it not to update.)  The one on github appears to be an iteration before I was done with it, hence the oddities in the registration,  (I was trying to see if registering it as a leveling guide would allow it to work. -- and obviously got sidetracked and didn't fix it back to dailies correctly.) That part I followed. (I think)

... but...

what do you mean about comments?  Did I put some comments somewhere else that should have made it to the final release and you are telling me that I put them the wrong place?  I think everything I expect to "go live" I put here (in the body of the wiki for that particular guide).  The only stuff I post on github nowadays, is stuff I want you to look at and either fix or advise me on.  The only other exception would be new guides which I put on my blog since I can't create wikis.

Ludovicus's picture

Re: HUH?

I mean the comments you have  at the top, like:

-- Date 1 Dec 2012
-- Who: Emmaleah
-- Log: 5.1 added a new achievement. adding mention of it to the guide

We the webscraping program looks for the text between:

WoWPro.Achievements:RegisterGuide(...]]
end)

and downloads that.  The comments up on top will not be copied into GitHub.

PS:  I tweaked a setting.  You should have permissions to create and delete your own wiki pages now.  Bad system setting.

Emmaleah's picture

ah, ok. those were mostly for

ah, ok. those were mostly for my own internal version control anyway :)... I tried to duplicate the same thing in the change log section of the wiki.  (like usually cut and paste) I won't put it in the top on the wiki anymore.  (but it will be there if I post it to github -- with the forementioned statement that what I put on github most likely isn't distribution ready.

And thanks. If I ever have any more new guides, I have a way to post them that won't require you to then move them.  I may at some point do one for the krasarang wilds horde side, but someone else may get to it first as my first priority right now is getting shadopan/august celestials rep done (not the guide... actually doing the dailies) and finishing my hunters last about 4 bubbles of 89 so I can start all over with the dailies... /sigh

Ludovicus's picture

Re: ah, ok. those were mostly for ... and Thanks

I have to say that I have enjoyed our collaboration very much.  

It's nice to have someone who keeps me on my toes and is willing to ask questions, especially the "Why can't this work better" kind.  

I'm just sorry I don't have more bandwith to keep up on things.  Between Blizzard mucking with things (I had tested things on the PTR, but they changed things between that build and the official one), new content on each release and things at home (Meperitab makes it very hard to think), and one functional eye it has been a challenge.

I really have to level up my Horde toon up; my poor Belf Blood DK would really help testing out these new guides. All those new scenarios, new raids, and pet battles.  

When I joined my first guild on Wow, one of the big concerns was what to do after you reached 80 and did "everything".  Now it seems almost impossible to finish "everything".

So, thanks again!   You have  help make the game more enjoyable for me on a personal level.  Never mind those 10-20 thousand people who dowload our addon!

OK, time to stop this drug induced babble .... and back to cutting a patch. 

 

Emmaleah's picture

sorry to introduce yet another complication to that mix... but..

In your newest iteration of the GetFriendshipReputation...

--- from wowpro_broker.lua lines 310-312

local friendID, friendRep, friendMaxRep, friendName, friendText, friendTexture, friendTextLevel, friendThreshold, nextFriendThreshold

if Friendship then

friendID, standingId, friendMaxRep, name, friendText, friendTexture, friendTextLevel, friendThreshold, nextFriendThreshold = GetFriendshipReputation(factionIndex);

you have assigned the variable defined in the function as friendrep to standingID. This is not what that variable is. That variable is the numeric value of the rep (on the full scale 0-42000), you could do math on that value to come up with standing id (ie. integer value of friendrep/8400)? or you could do string matching on the value friendTextLevel which will return the values {stranger...best friend} ... but, the way you have it now won't work.

I know and accept that you have a full scheudle like most people and this is a hobby. I am indead impatient, which is why I keep mucking around in it, trying to find how to do it myself. None of my ideas how to implement it have worked well. I had it working for best friend, but not for any of the lower lvls... I suspect because it was bypassing the whole calculation i was trying to do and instead going to the statement of else repmax=8

Now Ive gone to rambling, I better quit typing too... I hope you can find time for this Smiling

Ludovicus's picture

Re: sorry to introduce yet another complication to that mix...

OK. So notes for myself after breakfast (never program before breakfast and coffee):

    /dump GetFriendshipReputation(1283)

returns:
    [1]=1283 ; -- the rep ID
    [2]=5720 ; -- the current rep level (current level or absolute? we shall try Gina and see)
    [3]=42999; -- the max rep level
    [4]="Farmer Fung"  ; -- NPC name
    [5]="Farmer Fung considers you a stranger.  Farmer Fung likes Marsh Lilies and Wildfowl Roast"; -- NPC Text
    [6]= ; -- Some strange return
    [7]="Stranger" ; -- Text standing ID
    [8]=0 ; -- friend threshold
    [9]=8400 ; -- how many points to the next level

The next example:
    /dump GetFriendshipReputation(1281)

returns:
    [1]=1281;
    [2]=14300;
    [3]=42999;
    [4]="Gina Mudclaw";
    [5]="Gina Mudclaw considers you an Acquantance ...";
    [6]=;
    [7]="Acquaintance";
    [8]=8400;
    [9]=16800;

Since 14300 - 8400 = 5900, which is my standing in Acquaintance, [2] is an absolute level.

I will need to convert the text in [7] to a number.. Time for a table. Then I can use the table for both the if statements and the lookup.

Lucky I am still home from my eye operation Smiling.

Ludovicus's picture

Re: Re: sorry to introduce yet another complication to that mix.

OK.   Fix implemented and checked in with 15 minutes to go before my first conference call.

It still has a debug print statement in there that will need to be removed for a new cut.

It correctly identified Gina as an Acquaintance and computed the right earned rep.

Emmaleah's picture

tested - YAY!

I ran thru the guide and of course now that the logic is working found a couple of mistakes I had made, and some things that I think will improve it.  I made the changes to my personal copy and will test them tomorrow and add them  here if they work out :)

I noticed something that I dont know if it is fixable...If you get the rep needed for a quest from turning in the previous quest, the guide doesn't seem to know it, so doesnt tell you the next quest is available.  I think that is covered with my statement at the beginning of the guide to take every quest you see, (except the turn in dark soil items).

Also, if you pick up a quest out of order (not when the guide tells you to.  in this example it was A wolf in sheeps clothing - line 180 in my copy of the code) I was actually in the guide right after turning in oh sheepie (line 255)  the guide jumps backwards to the place where the C step for that quest is (line 192).  It was my idea that the guide would tell you to do that step the next time you run thru (i.e. tomorrow).  This is not new behavior, but I don't think I've commented on it before, since the whole guide in general wasnt working right. Is that normal? should it be normal?

Ludovicus's picture

RE: tested - YAY!

The jumping back behaviour is normal, and some guides, like the Nether Drake one, depend on it.

For good or ill, the way the engine works is that it all steps not marked as complete or skipped are eligible to be the "next" step when the current step is done.

The change in rep should be picked up, but only at the time the next step is computed.  There is a race condition such that the client may not report the change in rep before we have picked the next step.

I'll see if there is a different event we can pick up for that.  I think the World Events module had some special logic for rep and acheivement changes that might be more general.